Repository navigation
Reject NaN in Vector0 guards with ArgumentException [patch] - #424
Merged
Merged
Conversation
T.Sign(NaN) throws ArithmeticException for double, float and Half, so the documented ArgumentException was never reached. Check T.IsNaN first, then compare against zero instead of taking the sign. Fixes #326 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01QbGcYckSzgr6jPyoNYhWvA
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326
What changed
Vector0Guards.EnsureNonNegativeandEnsurePositivetested the value withT.Sign, which throwsArithmeticExceptionfordouble/float/HalfNaN, so generatedFrom{Unit}factories never reached their documentedArgumentException.T.IsNaNfirst and throwArgumentException("Magnitude must be a number; received NaN.", paramName).value < T.Zero/value <= T.Zero.Tests
Added to
Vector0InvariantTests:double.NaN,float.NaNandHalf.NaN→ArgumentExceptionSpeed,MassandWavelengthwith NaN →ArgumentException+∞still passesEnsurePositive, and-∞is still rejected byEnsureNonNegativeWith the guard change reverted, the three NaN tests fail; with it applied, they pass. The full
Semantics.Testsuite passes on net10.0 (1645 passed, 0 failed).🤖 Generated with Claude Code
https://claude.ai/code/session_01QbGcYckSzgr6jPyoNYhWvA
Generated by Claude Code