Repository navigation
[patch] Spell fully and half-diminished sevenths as vii°7 and viiø7 - #395
Merged
Merged
Conversation
RomanNumeralOf gave a fully diminished seventh no suffix after °, so Bdim7 read "vii°", the same as the triad. A half-diminished seventh read "vii°7", which ChordFromRomanNumeral parses back as fully diminished. QualitySuffix now emits "°7" for a diminished seventh and "ø7" for a diminished triad under a minor seventh, and ChordFromRomanNumeral reads ø as half-diminished. Fixes #289 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01FRrKUmpjRrYrUchAi6wGqR
|
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #289
What was wrong
Key.QualitySuffixhad two problems:7from a fully diminished seventh, soBdim7becamevii°, the same as the triad.m7b5) asvii°7, whichChordFromRomanNumeralreads back asBdim7. The chord changed identity on a round trip.Change (
Semantics.Music/Key.cs)QualitySuffix:ø+7.7, so the fully diminished seventh becomes°7.vii°),°maj7, and every non-diminished quality come out as before.ChordFromRomanNumeral: a leadingøin the suffix now passes through toChord.Parse, which already readsø/ø7asm7b5.°,dim,+andaugare unchanged.viiø7as an example.Tests (
RomanNumeralParseTests)Parse_IsInverseOfRomanNumeralOfnow also round-tripsvii°7andviiø7.Bdimgivesvii°andBdim7givesvii°7.Bm7b5givesviiø7and round-trips back toBm7b5.viiø7parses toBm7b5.Parse_LeadingToneDiminishedSeventh(vii°7→dim7) still passes, unchanged.With
Key.csreverted tomain, 4 of these fail. With the fix, the fullSemantics.Testsuite passes: 1469 passed, 0 failed, 8 skipped.The triage suggested pairing this with #281/#284 (
Chord.Parsereading°7/b5/Maj7). This PR doesn't changeChord.Parse. It only makes the Roman-numeral path use the°/øvocabularyChord.Parsealready accepts.🤖 Generated with Claude Code
https://claude.ai/code/session_01FRrKUmpjRrYrUchAi6wGqR
Generated by Claude Code