Repository navigation
Resolve release changelog paths against the workspace [patch] - #232
Open
matt-edmondson wants to merge 3 commits into
Open
matt-edmondson wants to merge 3 commits into
matt-edmondson wants to merge 3 commits into
Conversation
The changelog names are bare file names by default, and the release step used them as-is, so they resolved against the process's current directory. With --workspace pointing elsewhere, packages and the GitHub release shipped with no notes, or with the current directory's changelog. Resolve both names against the workspace before packing and before building the release options. Fixes #172 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01J9ABDLXQgwyGEboxA8DpmQ
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01J9ABDLXQgwyGEboxA8DpmQ
… release tests Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01J9ABDLXQgwyGEboxA8DpmQ
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172
What changed
ReleaseServicepassedLatestChangelogFileandChangelogFilestraight through toDotNetService.PackAsyncandReleaseOptions. They are bare file names by default, soFile.ExistsandPath.GetFullPathresolved them against the process's current directory instead of the workspace the metadata step wrote them to. A run with--workspacepointing elsewhere then shipped packages and the GitHub release with no notes, or with the changelog of whatever directory it was started from.Both names are now resolved against the workspace (
ResolveInWorkspace) before packing and before buildingReleaseOptions. Rooted paths and empty values pass through unchanged.I fixed this in
ReleaseServicerather than storing absolute paths inBuildConfigurationProvider, becauseMetadataServicestagesconfig.LatestChangelogFilewithgit addas a workspace-relative name. Changing the stored value would have changed that path too.Tests
ExecuteReleaseAsync_ResolvesChangelogsAgainstTheWorkspace_NotTheCurrentDirectorychanges the current directory to another directory that has its ownLATEST_CHANGELOG.md. It then checks that the pack gets<workspace>/LATEST_CHANGELOG.mdand that the release options carry both workspace paths. This test fails when the fix is reverted.ExecuteReleaseAsync_KeepsRootedChangelogPathsAsGivenchecks that a rooted path passes through unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01J9ABDLXQgwyGEboxA8DpmQ
Generated by Claude Code