Repository navigation
Pin --ignore-submodules=none in Status, Diff and Patch [patch] - #222
Merged
Merged
Conversation
A host's diff.ignoreSubmodules=all made Status() report clean, and Diff()/Patch() report nothing, while a submodule held unpushed commits and untracked files. Pinning none reports the submodule however the host is configured, the same way --untracked-files is already pinned. Fixes #190 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016vf9SXXkfFir6zugMSNM3b
…dows [patch] Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016vf9SXXkfFir6zugMSNM3b
Contributor
Author
|
Generated by Claude Code |
This was referenced Oct 17, 2026
Branches() silently drops any remote branch whose name ends in /HEAD (e.g. origin/release/HEAD)
#225
Closed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
What changed
GitStatusBuilder,GitDiffBuilderandGitPatchBuildernow always emit--ignore-submodules=none. Before this, a host'sdiff.ignoreSubmodules=allmadeStatus()reportIsClean == true, andDiff()/Patch()report nothing, while a submodule had a new commit and an untracked file. This is the same kind of host-config leak Status() can silently omit untracked files depending on the host's status.showUntrackedFiles config #112 closed for--untracked-files.submodule.<name>.ignorein.gitmodules. That fits the issue's goal of reporting the same answer on every host.Tests
GitSubmoduleTests.StatusDiffAndPatchReportASubmoduleTheHostIgnoresAsync. It setsdiff.ignoreSubmodules=allin the superproject's config, commits in the submodule and adds an untracked file there, then checks that Status, Diff and Patch all reportlibs/sub.Verification
Assert.IsFalse(status.IsClean)).🤖 Generated with Claude Code
https://claude.ai/code/session_016vf9SXXkfFir6zugMSNM3b
Generated by Claude Code