Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Solid accent surfaces now pick their text/glyph color by contrast instead of
always using white. A new
--app-primary-foregroundtoken is derived fromAPP_PRIMARY_COLOR(white, or near-black when the accent is light) and drivesevery solid
primary-600surface: the primary button, the login and sidebarbadges, the Connect-Drive button, the 404 link, the checkbox tick, and the
generated favicon / apple / manifest icons and the OG image.
Why
A light
APP_PRIMARY_COLORrendered white text on a near-white button — e.g.the login "Sign in" button became white-on-white and unreadable. The color is
now chosen by WCAG contrast, so any accent stays legible. The shipped green is
untouched (still white text), so existing instances render identically.