Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before deploying
GOOGLE_ENABLEDis now required inapps/api/.env— the API refuses to boot without it. Set"true"to keep Drive as it is;"false"needs no Google credentials at all.FATAL: database files are incompatible with server). Either pinPOSTGRES_VERSION=17or followdocs/upgrading-postgres.md— dump,down -v, restore.~6 GiB and OOMs at 2 GiB, which would strand you after the volume is already gone.
What's in it
GOOGLE_ENABLEDmirrorsS3_ENABLED. Off, the Drive section disappears from the sidebar andevery
/storage/drive/*and/google-auth/*route 404s, the public OAuth legs included.StorageRegistry.resolve()404s a disabled backendand
all()omits it, soGET /storage/statuslists only what is on — S3 included, which used torender a permanently dead "No S3 storage connected" card.
GoogleEnabledGuardcovers the OAuth controller, where there is no registry to go through..env.examplerequires just theswitch, same as S3.
note when there are none;
/no longer redirects to a hardcodeddrive.POSTGRES_VERSIONpicks the major (17 or 18) andPGDATAis pinned, because the 18 imagemoved its default to
/var/lib/postgresql/18/dockerand the volume mount would miss it.docs/now; the readme keeps a Documentation section pointing at them,and its remaining env lists moved into the
.env.examplecomments.Verification
pnpm build,pnpm lint, 242 unit (from 233) and 101 e2e (from 96) pass.google-disablede2e that boots withGOOGLE_ENABLED=falseand asserts[]statuses, 404severywhere, and no database access.
/healthreportedpostgres: up.project: dump,
down -v, restore on 18, rows and_prisma_migrationsintact,migrate deployfinds nothing pending. Step 7's image build OOMs on a 2 GiB VM, hence the note above.
starts again on the same volume.