Repository navigation
prplmesh: reconcile topology client state - #19
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
03497e8 to
258eeed
Compare
|
The four failing architecture jobs cannot be diagnosed from GitHub anymore: the run logs return HTTP 410 and all per-target log artifacts expired on 2026-09-21. GitHub also refuses a failed-job rerun, and the branch already contains the current base. A fresh PR synchronize/reopen run is required before this can be merged; keep the current failed checks blocking. |
Keep topology notifications multicast: the transport already delivers them to the local broker and controller, while unicast omits mesh neighbors. Complete connections only for stations attached to the reporting agent's BSS, and initialize their Wi-Fi interface type, channel and VAP ID. Verify the installed agent and controller versions through their early version-query paths instead of checking only generated metadata. Signed-off-by: Andrei Ovcharenko <[email protected]>
|
Проверены исходники prplmesh 6.0.1 и весь текущий diff. Исправлены подтверждённые P2: сохранена multicast-доставка соседям, topology reconciliation проверяет BSS отправившего агента и фактическую привязку станции, заполняет Wi-Fi type/channel/VAP. 12 патчей / 71 hunk применены без fuzz, целевые shell/version-сценарии прошли; теперь запускаются свежие изолированные сборки и runtime-тесты. Внешний review недоступен: лимиты и истёкшая авторизация резервного review. Выполнен собственный scoped/security проход без отключения CI-гейтов. |
1 participant
Topology responses can report associated stations without a preceding Client Association Event. Reconcile those stations to STATE_CONNECTED so BML includes active hostapd clients.\n\nValidation: full package patch stack applies cleanly to prplMesh 6.0.1; git diff --check passes. Live router currently reproduces 8 hostapd associations but 0 BML stations.