Repository navigation
CI test: prplmesh formatting round - #16
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26baefbdce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+352
to
+354
| + // Only an empty reply is a clean end-of-list; FAIL past the | ||
| + // restart budget leaves the VAP only partially walked. | ||
| + vap_enumerated = text.empty(); |
There was a problem hiding this comment.
When STA-FIRST finds no station, or STA-NEXT reaches the end of a populated BSS, hostapd returns FAIL, not an empty reply. This branch consequently retries normal completed walks and then leaves vap_enumerated false, so the later reconciliation skips that VAP and clients whose disconnect event was missed remain permanently recorded as connected. The normal end-of-list FAIL must be recognized, while handling a genuinely vanished cursor separately.
Useful? React with 👍 / 👎.
krotname
force-pushed
the
ci/prplmesh-forkci
branch
from
August 13, 2026 19:39
26baefb to
aa540ea
Compare
Add the prplMesh 6.0.1 EasyMesh controller and agent for stock OpenWrt. The package keeps the installed hostapd/wpad stack and drives it over the existing UCI, ubus, nl80211 and hostapd control sockets. The hostapd control interface client is a small self-contained implementation added by patch 120, so no hostapd source tree is downloaded, bundled or duplicated at build time and the system hostapd stays the only hostapd. Binaries install under /usr/libexec/prplmesh, read-only data under /usr/share/prplmesh, shared libraries under /usr/lib, configuration under /etc/config/prplmesh. Of the prplOS helper scripts only prplmesh_utils.sh is installed: patch 161 teaches its platform guard stock OpenWrt and the init's daily log roller invokes it; the other helpers stay uninstalled. Its option parsing needs util-linux getopt (the busybox applet is off by default), hence the getopt dependency. Stock builds run without NBAPI, so the controller skips the CurrentOperatingClassProfile data-model cleanup for radios without a data model path, and legacy vendor diagnostic measurements default to off while standard EasyMesh metrics stay enabled. The controller also registers radios that appear only in Topology Responses: some stock agents never run WSC onboarding for a band (Wi-Fi 7 units and their 6 GHz radio), and such radios, their BSSes and their clients stayed invisible otherwise. Agents in turn import clients that are already associated when the agent starts: patch 150 walks hostapd's STA-FIRST/STA-NEXT list on the nl80211 AP and monitor HALs and reconciles the result every 60 seconds, so stations that associated while the agent was down appear without waiting for a reassociation, and stale entries are disconnected only after a cleanly enumerated sweep. The init preflights every binary the selected management mode needs before registering any procd instance, and the example credentials ship empty so an enabled but unconfigured service fails validation loudly instead of deploying a published passphrase. A test-version.sh verifies the installed version from the shipped version file instead of probing daemons, and a test.sh checks the shipped log levels and the roll-helper install. Production log levels default to error, info, warning and fatal for file and syslog output of both daemons. Log retention is enforced by the upstream roll helper (its platform guard now accepts openwrt): the init prunes previous-boot logs once per boot before the daemons come up (a /var/run stamp keeps procd reload triggers, which re-enter start_service with the daemons live, from re-rolling their logs) and a procd-supervised roller repeats the roll daily; an image stripped of the helper runs without rotation instead of refusing to start. Link-metrics reporting no longer warns about wireless-capable radios deliberately not used for backhaul. An earlier revision of this integration, differing only in the wpa_ctrl client origin and the install prefix, runs on OpenWrt 25.12.5 mediatek/mt7622 with two Ethernet-connected EasyMesh agents. Ref: https://gitlab.com/prpl-foundation/prplmesh/prplMesh Ref: https://gitlab.com/kreout/prpl-mesh-mercusys/-/merge_requests/1 Signed-off-by: Andrei Ovcharenko <[email protected]>
krotname
force-pushed
the
ci/prplmesh-forkci
branch
from
August 14, 2026 18:59
aa540ea to
4fdfe78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-CI matrix for openwrt#30071 head 92d50f6. Not for merge.