Repository navigation
Conversation
Add the prplMesh 6.0.1 EasyMesh controller and agent for stock OpenWrt. The package keeps the installed hostapd/wpad stack and drives it over the existing UCI, ubus, nl80211 and hostapd control sockets. The hostapd control interface client is a small self-contained implementation added by patch 120, so no hostapd source tree is downloaded, bundled or duplicated at build time and the system hostapd stays the only hostapd. Binaries install under /usr/libexec/prplmesh, read-only data under /usr/share/prplmesh, shared libraries under /usr/lib, configuration under /etc/config/prplmesh. Of the prplOS helper scripts only prplmesh_utils.sh is installed: patch 161 teaches its platform guard stock OpenWrt and the init's daily log roller invokes it; the other helpers stay uninstalled. Its option parsing needs util-linux getopt (the busybox applet is off by default), hence the getopt dependency. Stock builds run without NBAPI, so the controller skips the CurrentOperatingClassProfile data-model cleanup for radios without a data model path, and legacy vendor diagnostic measurements default to off while standard EasyMesh metrics stay enabled. The controller also registers radios that appear only in Topology Responses: some stock agents never run WSC onboarding for a band (Wi-Fi 7 units and their 6 GHz radio), and such radios, their BSSes and their clients stayed invisible otherwise. Agents in turn import clients that are already associated when the agent starts: patch 150 walks hostapd's STA-FIRST/STA-NEXT list on the nl80211 AP and monitor HALs and reconciles the result every 60 seconds, so stations that associated while the agent was down appear without waiting for a reassociation, and stale entries are disconnected only after a cleanly enumerated sweep. The init preflights every binary the selected management mode needs before registering any procd instance, and the example credentials ship empty so an enabled but unconfigured service fails validation loudly instead of deploying a published passphrase. A test-version.sh verifies the installed version from the shipped version file instead of probing daemons, and a test.sh checks the shipped log levels and the roll-helper install. Production log levels default to error, info, warning and fatal for file and syslog output of both daemons. Log retention is enforced by the upstream roll helper (its platform guard now accepts openwrt): the init prunes previous-boot logs once per boot before the daemons come up (a /var/run stamp keeps procd reload triggers, which re-enter start_service with the daemons live, from re-rolling their logs) and a procd-supervised roller repeats the roll daily; an image stripped of the helper runs without rotation instead of refusing to start. Link-metrics reporting no longer warns about wireless-capable radios deliberately not used for backhaul. An earlier revision of this integration, differing only in the wpa_ctrl client origin and the install prefix, runs on OpenWrt 25.12.5 mediatek/mt7622 with two Ethernet-connected EasyMesh agents. Ref: https://gitlab.com/prpl-foundation/prplmesh/prplMesh Ref: https://gitlab.com/kreout/prpl-mesh-mercusys/-/merge_requests/1 Signed-off-by: Andrei Ovcharenko <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a5a1168e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| jobs: | ||
| wait-for-formalities: | ||
| name: Wait for FormalityCheck | ||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - name: Wait for Check Run | ||
| uses: lewagon/[email protected] | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| check-name: 'FormalityCheck / Git & Commits' | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| wait-interval: 5 | ||
|
|
||
| build: |
There was a problem hiding this comment.
When this CI-only commit lands on the main branch, the build workflow no longer waits for FormalityCheck / Git & Commits, so every pull request—including one that has already failed repository formalities—starts the reusable multi-architecture build and this workflow can report success independently. Restore the removed wait-for-formalities job and the build's needs dependency before merging.
Useful? React with 👍 / 👎.
| + sta_caps_from_ht(HT_MCS, options["ht_caps_info"], msg->params.capabilities); | ||
| + if (radio_5G) { | ||
| + sta_caps_from_vht(VHT_MCS, options["vht_caps_info"], msg->params.capabilities); | ||
| + } |
There was a problem hiding this comment.
For clients imported on 2.4 GHz or 6 GHz, this condition skips sta_caps_from_vht(), which is the only helper in this parser that assigns capabilities.wifi_standard; the zero-initialized value is therefore sent in the association notification even when HT capabilities were successfully parsed. Existing clients on those bands are consequently registered with an unknown/incorrect Wi-Fi standard, so the parser should assign the standard from HT/legacy/HE data independently of the 5 GHz-only VHT path.
Useful? React with 👍 / 👎.
|
Matrix green on 9a5a116 (all 10 jobs): https://github.com/krotname/packages/actions/runs/31423910311 — closing, CI-only PR. |
1 participant
Fork-CI matrix for openwrt#30071 head 4161be6 (round-3 fixes: reload-safe startup log roll, patch 170 reformat). Upstream matrix is action_required. Not for merge.