Skip to content

CI: run the Swift job on macOS 27 too, and raise its time limits - #85

Merged
krishhgg merged 3 commits into
mainfrom
ci/macos-27-runner
Oct 12, 2026
Merged

krishhgg merged 3 commits into
mainfrom
ci/macos-27-runner

Conversation

@krishhgg

@krishhgg krishhgg commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Phase 1 of the testing plan: CI tests on every macOS major GitHub hosts, and long test runs get time to finish.

What changes

CI results

Commit Job macOS Xcode Tests
09baad9 macOS 26 26.6.2 (25G83) 26.6 (17F113) 1223 run, 10 skipped, 0 failed
09baad9 macOS 27 27.0.1 (26A434) 27.0 (27A266a) 1223 run, 10 skipped, 0 failed
d328730 macOS 26 26.6.2 (25G83) 26.6 (17F113) 1223 run, 10 skipped, 0 failed
d328730 macOS 27, attempt 1 27.0.1 (26A434) 27.0 (27A266a) 1 test failed: the fake sudo flake fixed by #89
d328730 macOS 27, attempt 2 27.0.1 (26A434) 27.0 (27A266a) 1223 run, 10 skipped, 0 failed

The 10 skips are UIStatusTests cases that need a non-zero pill stagger. The hosted images have Reduce Motion on, so the stagger is zero. Swift is 6.3.3 on macOS 26 and 6.4 on macOS 27.

The attempt 1 failure was testTheSupervisorOutlivesItsRunAndGroupSignalsAndHoldsTheLockUntilItReapsTheCommand. The test's fake sudo logged each group signal twice. That is a race in the fake, not in the app, and it is on main too. #89 fixes it. Until #89 merges, the macOS 27 job can fail on it now and then, and so can the macOS 26 job.

Checks

  • actionlint 1.7.12 passes locally with the new config, and failed on xcode-27 without it.
  • zizmor runs in CI. The matrix label reaches the run block through env, not a ${{ }} expression in the script.
  • Codex (gpt-6.1-sol, xhigh, read-only) reviewed 09baad9 and found the timeout comment wrong: it left out the build. cac3718 fixes the comment. Codex found nothing at d328730.

CI-only PR: no Mac report needed.

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no blocking issues were found.

Summary

CI runs Swift tests and release builds on both macOS 26 and macOS 27.

  • Swift CI checks macOS 26 and 27 in separate 60-minute jobs.
  • The Swift test watchdog waits 50 minutes before stopping a run.

Reviews (2) · Last reviewed commit: "CI: make the macOS 27 job a normal job" · Reviewed by Greptile

krishhgg and others added 3 commits October 11, 2026 16:32
The Swift job now runs on macos-26 and on the xcode-27 image (macOS 27,
public preview). The macOS 27 job reports its failures without failing
the run until the macOS 27 fixes land. Each run writes the macOS build,
Xcode, Swift and runner image it used to the job summary, since GitHub
picks the point release and moves it forward.

The job timeout goes from 30 to 60 minutes and the test watchdog from
20 to 50, so long RecoveryScriptTests runs finish instead of being
sampled and killed while still progressing.

actionlint 1.7.12 predates the xcode-27 label, so .github/actionlint.yaml
lists it.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
swift test builds the tests inside the watched window, so the build is
not outside the 50 minutes. On main the step took 11 to 16 minutes in
October 2026, not about 3. Codex's review of 09baad9 found the first.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
The first run on xcode-27 (macOS 27.0.1, 26A434, Xcode 27.0) passed all
1223 tests, with the same 10 Reduce Motion skips as macOS 26. A failure
there is now a regression, so it fails the run like the macOS 26 job.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@krishhgg
krishhgg merged commit 3b5f269 into main Oct 12, 2026
8 of 9 checks passed
krishhgg added a commit that referenced this pull request Oct 12, 2026
Brings in #89's fake sudo change, so CI lints the fake's new text, and #85's merge.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
krishhgg added a commit to 0xRafie/Insomnia that referenced this pull request Oct 12, 2026
The macOS 27 job on krishhgg#85 (run 38186117753, d328730) failed
testTheSupervisorOutlivesItsRunAndGroupSignalsAndHoldsTheLockUntilItReapsTheCommand.
The test sends the backstop's process group one SIGTERM and one SIGHUP
and expects the fake sudo to log each once. It logged SIGHUP, SIGTERM,
SIGHUP, SIGTERM, then the supervisor's SIGTERM: both group signals twice.

hang_on_term's wait loop ran `$(date +%s)` in every condition. Bash 3.2
starts a command substitution with the shell's pending traps and trap
commands, and the child runs pending traps before its first command. A
signal that lands after the condition's own trap check and before that
fork runs the trap in the child and again in the shell.

The watchdog now runs on bash's SECONDS, so the wait forks nothing but
/bin/sleep, and the deadline is set before the pid is published, so a
group signal sent as soon as the pid appears finds no `date` to kill.
No assertion changed.

This is krishhgg#34's e52ea07 and b96f62a, which fixed the same race there;
the text matches krishhgg#34's head, so krishhgg#34 merges cleanly over it.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
krishhgg added a commit to 0xRafie/Insomnia that referenced this pull request Oct 12, 2026
krishhgg#66 moved the real-Mac checklist from docs/release-validation.md to docs/releasing.md, so this PR's sleep guard read back row moves there too, under Sessions and recovery. Brings in krishhgg#85's macOS 27 CI job and krishhgg#89's test fix.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
krishhgg added a commit to D4TBot/Insomnia that referenced this pull request Oct 12, 2026
krishhgg#66 moved the real-Mac checklist from docs/release-validation.md to docs/releasing.md. This PR's two checklist changes move there: the darkening-refused item now says a macOS major other than 26 or 27, and the macOS 27 Low Power Mode item goes under Sessions and recovery. The October 10 macOS 27.0.1 results stay in release-validation.md. Brings in krishhgg#85's macOS 27 CI job and krishhgg#89's test fix.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant