Repository navigation
Fix keyboard focus when entering session duration - #143
Open
ilya-the-frog wants to merge 2 commits into
Open
ilya-the-frog wants to merge 2 commits into
ilya-the-frog wants to merge 2 commits into
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Owner
|
Thank you for this. Your head commit b6ee899 is merged unchanged into #145, together with five other menu bar pull requests that change the same files. When #145 merges, GitHub marks this pull request as merged too, with your commits and your authorship. Please don't push to this branch from now on. A new commit wouldn't be in #145, so this pull request would stay open instead of showing as merged. If you want to change something, comment here and I'll add it to #145. #145's description lists the conflicts resolved in its merge commits and the two maintainer fixes after them. 🤖 Generated with Claude Code |
krishhgg
added a commit
that referenced
this pull request
Oct 24, 2026
Integration branch integration/menu-controls at ce8ba6f, built and installed with install.sh --app in a macOS 27.0.1 VM: hold-to-end, End session in the menu, the Time left row, the countdown toggle, End time with a time zone change, typing into the pills (#143), and displays asleep. Pill-click sheets for ce8ba6f, main e242782, e537b3a, 091e413 and 25e6f15. Scripts in scripts/. Co-Authored-By: Claude Opus 5.5 <[email protected]>
krishhgg
added a commit
that referenced
this pull request
Oct 24, 2026
On macOS 27 a press on the status item deactivates Insomnia while the button is still down. The catcher panel from #143 then resigns key, and its focus-lost handler collapsed the pills about 1 ms after the press, before the pill's tap (on release) could focus it. So a pill click closed the pills, and #93's fix for the same click was lost in the merge. Focus lost with the pointer on the item now waits for the release: a pill takes focus back through focus(_:), and if the catcher is still not key 0.2 s after the release the pills close, so typing never goes to another app while they show. Focus lost anywhere else collapses at once, as before. Checked in a macOS 27.0.1 VM: Minutes and Days clicks keep the pills open, typed digits land in them and start or extend the session, and a click elsewhere, Cmd-Tab, Escape, an eye click and a drag off a pill still close them. The hold-to-end checks still pass. Co-Authored-By: Claude Opus 5.5 <[email protected]>
krishhgg
added a commit
that referenced
this pull request
Oct 24, 2026
P1 and P2 pill clicks, X1 to X15, hold-to-end (part A) and the #143 typing checks (part F) against 732de03, plus X11 against the first fix (ce8ba6f with fix145.diff) as a control. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the duration pills are open, digits can still reach the previously active app (for example, a search field in Telegram). The pills also stay visible while the Settings/Quit menu is handling input.
Activate Insomnia and make its typing panel key, using the same activation call as SettingsWindow. Remember the previous app and return focus when typing ends, provided Insomnia still owns activation. Losing the key window dismisses the pills without taking focus back; opening the context menu dismisses them before menu tracking begins.
This branch starts from main and contains only the input-focus fix. It is independent of #142 (Login Items attribution).
Validation:
Not run: physical-keyboard validation of the installed PR head, extension/refused-start paths, context-menu interactions, and multiple displays/Spaces. The isolated probe is not the installed-head real-Mac report required by CONTRIBUTING before merge. The currently installed #142 validation build has not been replaced.
The reviewed changes appear safe to merge; the previous Settings-focus issue is fixed and no new actionable issue was found.Summary
The PR activates Insomnia while users enter a duration and returns focus when typing ends.
Reviews (2) · Last reviewed commit: "Keep focus in Insomnia when clicking its..." · Reviewed by Greptile