Repository navigation
feat(design-first): paso 26 smoke e2e RF-16 - #564
Merged
Merged
Conversation
Añade design-first.smoke.spec.ts (golden three-screens → contrato → MDD simulado → cascada → handoff) y documenta src/smoke/README.md. Flag DESIGN_FIRST_ENABLED sigue apagado; 26.6 pendiente de OK de Jorge. Corrige ?? NEW en estimation.service para el guard anti-literal.
acceptBaseline llama captureBaseline, que usa project.findUnique desde Design-First; el doble de Prisma en el spec faltaba ese método.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/api/src/smoke/design-first.smoke.spec.ts: fixturethree-screens→ compile-contract (PAG golden) → MDD simulado (§3/§4) →api_contracts+ pantallas →designFirstRepoHandoffFilesconvalidateOpenApi31y fixtures JSON parseables.src/smoke/README.md, CHANGELOG y cierre parcial enTASKS.md(26.6 encendido de flag pendiente de aprobación de Jorge).estimation.service.tsusaProjectTypeEnum.enum.NEW(guard anti-literal).Test plan
pnpm --filter @theforge/api test --test-path-pattern=design-first.smokepnpm run typecheck+pnpm run buildroute-coverage,project-type-literalspnpm testmonorepo completo (falla preexistentebusiness-rules/ vitest).envlocal)Release
DESIGN_FIRST_ENABLEDno se enciende en este PR (release N+1 solo con OK explícito).