Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
adm-zipto 0.6.1 insdkandserver.What and why
adm-zip 0.6.0is covered by two advisories:Both
sdk/package.jsonandserver/package.jsonpinnedadm-zip 0.6.0as a runtime dependency. 0.6.1 is the fix version for both advisories; no other package pins changed.How it was tested
npm ci --ignore-scriptssucceeds in bothsdk/andserver/against the updated lockfiles (integrity hashes verified by npm).node_modules/py/node_modules/adm-zip 0.5.18copy of@bjia56/portable-pythonis pinned separately by that package and is out of scope here.Note:
0.5.18(the nested copy) is also in range for the same advisories, but it is locked by the parent package@bjia56/portable-python 0.1.141; bumping it needs a@bjia56/portable-pythonrelease, so this PR only clears the direct dependency.Scope:
sdk/package.json,sdk/package-lock.json,server/package.json,server/package-lock.json.