Fix admin deletion cascade and valuation classification - #7
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: George Kour <[email protected]>
Co-authored-by: George Kour <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
ON DELETE CASCADE, but the default SQLite configuration does not enable FK cascades. Deleting a user could leave executions, reports, chats, token usage, API keys, schedules, and other user-owned rows behind.Trustas ETFs/indexes. REIT-style equities such as Digital Realty Trust could skip DCF/comps and receive aggregate ETF-style valuation output.Root cause
delete_useronly deleted theUserORM object and assumed cascades would remove all related rows._is_index_or_etfused broad substring matching across metadata and names (FUND,TRUST, provider names), causing false positives.Fix
Trust/Fundfalse positives.Validation
python3 -m unittest backend.tests.test_admin_service backend.tests.test_valuation_summary