Fix admin user deletion cascading - #4
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: George Kour <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Admin user deletion relied on database-level
ON DELETE CASCADEfor most user-owned tables. The default SQLite engine does not enable foreign-key cascades, so deleting a user could leave private reports, report views, chats, API keys, schedules, and token ledger rows orphaned after the account row was removed.Root cause
delete_useronly calleddb.delete(user), while theUserORM model only cascades subscriptions and profile relationships. Other dependencies are modeled only with database foreign keys.Fix
Explicitly delete user-owned dependent records in dependency order before deleting the user row, with rollback on failure.
Validation
python3 -m unittest backend.tests.test_admin_servicegit diff --check HEAD~1..HEAD