Fix valuation metadata loss and stock list updater safety#3
Draft
cursor[bot] wants to merge 2 commits into
Draft
Fix valuation metadata loss and stock list updater safety#3cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: George Kour <[email protected]>
Co-authored-by: George Kour <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
ReportDatawith an incomplete field list, dropping persisted valuation metadata. The new valuation snapshot UI would show N/A/hidden values even though the valuation report stored fair value, method summary, bridge, sensitivity, and assumptions.Root cause
backend/routers/tickers.pyduplicated partialReportData(...)mappings instead of preserving the fullReportServicereport dictionary shape.scripts/update_stock_lists.pytreated non-empty fetched lists as valid without count or removal sanity checks.Fix
--forceoverride for deliberate large changes.Validation
PYTHONPATH=backend:. python3 -m unittest backend.tests.test_ticker_widgets_api scripts.test_update_stock_lists