Fix critical admin deletion and valuation regressions#12
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: George Kour <[email protected]>
Co-authored-by: George Kour <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
executions -> reports -> report_views, deleting shared analysis reports and other users' view history when deleting a content creator. The system account was also deletable, risking loss of cron/sync-generated platform reports.TrustorFundas ETF/index instruments, causing REITs and similar equities to skip stock DCF/comps valuation and silently show the wrong valuation methodology.valuation_key_assumptionsat 5 even though the deterministic tool can emit more, causing structured valuation metadata to be dropped on validation failure.Root cause
admin_service.delete_userdeletedUserrows directly without preserving owned executions/reports or protecting platform/admin accounts._is_index_or_etfused broad substring matching across names and metadata instead of respecting explicit instrument types.Fix
Trust/Fundmatches.Validation
python3 -m unittest backend.tests.test_admin_service backend.tests.test_valuation_summary