Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Firmware 17 reports the Boost register as
REG_HOT_WATER_BOOST, while the API currently looks only forREG__HOT_WATER_BOOST. This causes the Boost state to be unavailable on affected pumps.Look for the new name first, then fall back to the legacy name. Keep the register ID from whichever name is found so subsequent writes target the correct register. This way the fix is backward-compatible.
Verification
pytest -q ThermiaOnlineAPI— 7 passed.Live writes through the patched API have not yet been tested.
Fixes #54.
Related: klejejs/ha-thermia-heat-pump-integration#134 and klejejs/ha-thermia-heat-pump-integration#140.
The hot water boost option becomes available again in Home Assistant with this fix:
