Repository navigation
Conversation
- Catch requests.exceptions.RequestException and raise NetworkException - Raise NetworkException on non-200 HTTP response codes - Add unit tests verifying exception raising on write failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
__set_register_valuelogs an error on non-200 HTTP responses and network errors, but silently returnsNone.In caller applications like Home Assistant (ha-thermia-heat-pump-integration#146), this causes the integration to assume register writes (e.g. setting target temperatures or toggling switches) succeeded, optimistically updating the UI state when the physical heat pump never accepted the command.
Changes
requests.exceptions.RequestExceptionduringPOST /Registersand raiseNetworkException.NetworkExceptionon non-200 response codes.ThermiaOnlineAPI/tests/test_set_register_value.py.