Bump CI to JRuby 10, declare csv as an explicit dependency - #661
Merged
Merged
Conversation
- CI: bump jruby-9.4.15.0 -> jruby-10.0.6.0 (both mysql2/postgresql matrix legs).
- README: update Ruby/JRuby version requirement text accordingly.
- kaui.gemspec: csv is a "bundled gem" as of Ruby 3.4 (no longer a default
gem), so it must be an explicit dependency for it to be available via
Bundler.require. Several controllers (accounts, invoices, payments,
audit_logs, account_timelines) `require 'csv'` directly; without this,
Rails eager loading (production/WAR boot) crashes with:
LoadError: cannot load such file -- csv
Validated locally: bundle install + Rails boot + JDBC/SQLite connection
all succeed unmodified under real JRuby 10.1.1.0/JDK21 with this change.
Co-authored-by: Copilot <[email protected]>
pierre
approved these changes
Sep 8, 2026
A support engineer independently hit this same crash and pointed to a now-filed JRuby bug (jruby/jruby#9651): assigning to an outer local variable named 'it' inside a block silently creates a block-local shadow instead of updating the outer one on JRuby 10, breaking sorbet-runtime's signature-validation loop counter (T::Private::Methods::Signature#each_args_value_type). No functional change - just documenting the confirmed root cause for future readers. Co-authored-by: Copilot <[email protected]>
Defense-in-depth fix, part of the same root-cause investigation as the CI failures fixed in killbill-kpm-ui and killbill-email-notifications-ui (see their jruby10-upgrade branch commits for full details). This repo currently resolves json 2.x thanks only to an INCIDENTAL transitive constraint (rubocop's own `json ~> 2.3` dependency in whatever version bundler happens to resolve here) - not a real guarantee. rubocop 1.90.0 (released 2026-08-24) loosened its own json dependency to `json >= 2.3` (no upper bound), so this repo's unpinned `gem 'json'` could silently start resolving json 3.x on any future bundle install (Gemfile.lock isn't committed in this repo), exactly as already happened in killbill-kpm-ui and killbill-email-notifications-ui once json 3.0.0/3.0.1 were published (2026-09-07/08). json 3.0 dropped the quirks_mode keyword that ActiveSupport::JSON.encode still passes to JSON.generate (not fixed until Rails 8.1.0), raising ArgumentError on any #to_json call - including killbill-client's model classes, used throughout this engine. Pinned `gem 'json', '~> 2.21'` explicitly rather than relying on rubocop's transitive constraint. Verified: bundle install resolves json (2.21.2); test suite passes. Co-authored-by: Copilot <[email protected]>
tungleduyxyz
force-pushed
the
jruby10-upgrade
branch
from
September 9, 2026 14:46
d97c008 to
7de453c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of the JRuby 10 upgrade (see workspace plan). Rails stays on ~> 7.2 for this phase; Rails 8 is a follow-on phase gated on a stable
activerecord-jdbc-adapterrelease.jruby-9.4.15.0tojruby-10.0.6.0(LTS line; JRuby 10.1.x is still "tip"/experimental per upstream).csvas an explicit gemspec dependency: it became a "bundled gem" (no longer a default gem) as of Ruby 3.4, which JRuby 10 targets. Several controllers (accounts, invoices, payments, audit_logs, account_timelines) require csv directly for CSV export; without an explicit dependency, Rails eager loading (production boot) crashes withLoadError: cannot load such file -- csv.Validation
Confirmed locally with real JRuby 10.1.1.0 + JDK 21:
bundle installresolves cleanly (no Gemfile/gemspec changes needed beyond this PR).RAILS_ENV=test bundle exec rails runnerboots successfully and establishes a JDBC/SQLite connection.Rails.application.eager_load!no longer raises.Also dropped the now-unnecessary JRuby-9.4.10 jar-dependencies ~> 0.4.1 workaround gem (upstream jruby/jruby#7262 is closed).