Skip to content

Added official election name to some models - #4225

Open
Lionqueen94 wants to merge 3 commits into
mainfrom
4175-missing-election-name-on-model-31-2-bijlage-1
Open

Lionqueen94 wants to merge 3 commits into
mainfrom
4175-missing-election-name-on-model-31-2-bijlage-1

Conversation

@Lionqueen94

@Lionqueen94 Lionqueen94 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Closes #4175

What & why

  • Added election official name to Na 31-2 Bijlage 1:
image image image
  • Also added election official name to Na 14-1 versie 2, Na 14-2 Bijlage 1, Na 31-1 Inlegvel and Na 31-2 Inlegvel

Tested with "Algemeen bestuur van het hoogheemraadschap van Schieland en de Krimpenerwaard 2023" and this still fits

How to test

Review the pdf diffs

Reviewer notes

@Lionqueen94 Lionqueen94 self-assigned this Nov 2, 2026
@Lionqueen94 Lionqueen94 linked an issue Nov 2, 2026 that may be closed by this pull request
@Lionqueen94
Lionqueen94 marked this pull request as ready for review November 2, 2026 11:40
@Lionqueen94
Lionqueen94 requested a review from a team as a code owner November 2, 2026 11:40
jorisleker
jorisleker previously approved these changes Nov 2, 2026

@jorisleker jorisleker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one question: how does this display "Wetterskip Fryslân" or "Hoogheemraadschap Hollands Noorderkwartier"? As such, or will it be "Waterschap Fryslân"? Should be the first :-)

@Lionqueen94

Copy link
Copy Markdown
Contributor Author

LGTM, with one question: how does this display "Wetterskip Fryslân" or "Hoogheemraadschap Hollands Noorderkwartier"? As such, or will it be "Waterschap Fryslân"? Should be the first :-)

It will show Wetterskip or Hoogheemraadschap when applicable 👍

@Lionqueen94 Lionqueen94 added the typst Typst templates label Nov 2, 2026
jorisleker
jorisleker previously approved these changes Nov 2, 2026

@jorisleker jorisleker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liked the shorter one better as it is easier to distinguish multiple water authorities if there are more then one, but can approve this as well as this is what JKA wants.

@Lionqueen94

Copy link
Copy Markdown
Contributor Author

Liked the shorter one better as it is easier to distinguish multiple water authorities if there are more then one, but can approve this as well as this is what JKA wants.

I agree, but using the official name is more in line with what is shown on all documents. The shorter version is only used in Abacus itself. And this is what @ring-ring-ring asked me to change.

@jorisleker

Copy link
Copy Markdown
Contributor

Will try and challenge this later once models need another revision. Okay for now, as I said

cikzh
cikzh previously approved these changes Nov 3, 2026
@ring-ring-ring

Copy link
Copy Markdown
Contributor

Awaits final approval from the organisation.

@Lionqueen94
Lionqueen94 marked this pull request as draft November 5, 2026 09:49
…jlage 1, Na 31-1 Inlegvel and Na 31-2 Inlegvel
@ring-ring-ring

Copy link
Copy Markdown
Contributor

Approved by the organisation, we added some of the other documents as well.

@Lionqueen94
Lionqueen94 marked this pull request as ready for review November 5, 2026 11:20
@Lionqueen94
Lionqueen94 requested a review from cikzh November 5, 2026 11:20
@Lionqueen94 Lionqueen94 changed the title Added election name to Model Na 31-2 bijlage 1 Added official election name to some models Nov 5, 2026
@Lionqueen94 Lionqueen94 added the needs-backport/1.2 Needs backporting to the 1.2 release branch label Nov 5, 2026
@Lionqueen94
Lionqueen94 enabled auto-merge November 5, 2026 15:03

@jorisleker jorisleker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great we can do this, and even better we also add this to more models.

✅ reviewed the diffs and looks good to me

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport/1.2 Needs backporting to the 1.2 release branch typst Typst templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing election name on Model 31-2 Bijlage 1

4 participants