Repository navigation
Added official election name to some models - #4225
Lionqueen94 wants to merge 3 commits into
Conversation
jorisleker
left a comment
There was a problem hiding this comment.
LGTM, with one question: how does this display "Wetterskip Fryslân" or "Hoogheemraadschap Hollands Noorderkwartier"? As such, or will it be "Waterschap Fryslân"? Should be the first :-)
It will show Wetterskip or Hoogheemraadschap when applicable 👍 |
jorisleker
left a comment
There was a problem hiding this comment.
Liked the shorter one better as it is easier to distinguish multiple water authorities if there are more then one, but can approve this as well as this is what JKA wants.
I agree, but using the official name is more in line with what is shown on all documents. The shorter version is only used in Abacus itself. And this is what @ring-ring-ring asked me to change. |
|
Will try and challenge this later once models need another revision. Okay for now, as I said |
|
Awaits final approval from the organisation. |
…jlage 1, Na 31-1 Inlegvel and Na 31-2 Inlegvel
|
Approved by the organisation, we added some of the other documents as well. |
jorisleker
left a comment
There was a problem hiding this comment.
🎉 Great we can do this, and even better we also add this to more models.
✅ reviewed the diffs and looks good to me
Closes #4175
What & why
Tested with "Algemeen bestuur van het hoogheemraadschap van Schieland en de Krimpenerwaard 2023" and this still fits
How to test
Review the pdf diffs
Reviewer notes