Repository navigation
Skip population_monotonicity fuzz when P 9 and P 10 are applied - #4224
Merged
stacktraceghost merged 2 commits intoNov 5, 2026
Merged
stacktraceghost merged 2 commits into
stacktraceghost merged 2 commits into
Conversation
cikzh
marked this pull request as draft
November 2, 2026 11:27
cikzh
marked this pull request as ready for review
November 2, 2026 11:28
Contributor
|
I think we also need to check the if the second allocation has P 9 + P 10, not just the first allocation. And we can check for |
cikzh
marked this pull request as draft
November 2, 2026 13:01
cikzh
force-pushed
the
4136-skip-p-9-and-p-10-in-population_monotonicity-target
branch
3 times, most recently
from
November 2, 2026 13:48
fc483ce to
7675ef0
Compare
cikzh
force-pushed
the
4136-skip-p-9-and-p-10-in-population_monotonicity-target
branch
from
November 2, 2026 13:59
7675ef0 to
b5107d7
Compare
cikzh
marked this pull request as ready for review
November 2, 2026 13:59
cikzh
force-pushed
the
4136-skip-p-9-and-p-10-in-population_monotonicity-target
branch
from
November 2, 2026 14:26
b5107d7 to
0c14b7c
Compare
population_monotonicity fuzz when P 9 and P 10 are applied
jschuurk-kr
approved these changes
Nov 5, 2026
jschuurk-kr
left a comment
Contributor
There was a problem hiding this comment.
Reviewed code. Performed the steps in "How to test".
stacktraceghost
approved these changes
Nov 5, 2026
stacktraceghost
left a comment
Contributor
There was a problem hiding this comment.
Tested, fuzz artifact works on this branch and not on main. Checked code.
stacktraceghost
deleted the
4136-skip-p-9-and-p-10-in-population_monotonicity-target
branch
November 5, 2026 15:11
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes
During #4136 the fuzzer hit on a case where P 9 and P 10 were applied. When this happens in Abacus, the user will be presented a warning that this happened and that they should contact Kiesraad. See:
abacus/backend/apportionment/src/seat_assignment/structs.rs
Lines 33 to 35 in 472d08d
See for more explanation and context: #3219 and #1357
How to test
See that it doesn't crash. It does crash when running this on main