Repository navigation
fix: close the remaining writer-contract and layering gaps from the review - #61
Merged
Merged
Conversation
…eview - check flush/close of the diagnostics envelope file and report E-INT-002 in both the stderr log and the stdout envelope - check flush/close in the allocation report writer - escape task/lock names in the hand-written metrics JSON - sum WCET intervals in 64-bit and use as_task_node in the WCET writer - stop creating parent directories in the PTPN DOT writer - harden the CMake check-isolation guard (runs after target definitions, covers dbm/reductions, resolves aliases and matches raw/genex entries) - remove spdlog types from app/logging.h via a logging.cpp implementation - share lock-type and time-range helpers from model/types.h; simplify the unreachable post-CS label branch - sync architecture/diagnostics docs - add /dev/full, missing-parent, JSON-escaping and WCET-overflow regressions Co-Authored-By: Claude Code <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #60 from a verification
/code-reviewpass on the merged fixes. Closes the remaining I/O-contract gaps, hardens the CMake isolation guard, and removes the remaining duplicated helpers.Writer I/O contract
--diagnostics-fileenvelope: flush/close are now checked; a delayed write failure addsE-INT-002, is reported on stderr, updates the exit code, and appears in the stdout envelope when--diagnostics jsonis also set.save_report_json) now usesptpn::finish_outputand returnsfalseon write/flush/close failure (the caller already maps that toE-INT-002)./dev/full, PTPN DOT missing parent, success-log detection for[PETRI_EXPORT].Robustness
as_task_node.app/logging.hno longer exposes spdlog types; implementations moved tologging.cpp, keeping spdlog PRIVATE.model/types.h(removes the fourth mutex/spin copy and the parse/exportformat_rangeduplicate); the unreachable[Post:<lock>]branch is simplified.CMake check-isolation guard
ptpn_dbm/ptpn_reductions; aliases are resolved viaALIASED_TARGET; raw dependency entries (including generator expressions) are matched against the forbidden names before being skipped.ptpn_reachability(direct and via an alias) intoptpn_app_support: both abort configure; reverted afterwards.Docs
architecture.md: export no longer depends onptpn_metrics; the SCG writer still depends onptpn_reachability.diagnostics.md: output-writer coverage is now uniform.Verification
cmake --build build --parallelctest --test-dir build --output-on-failure: 331/331 passedtest/golden/untouched)/dev/fullrepros: diagnostics file, allocation report, all export writers → exit 1 +E-INT-002; PTPN DOT missing parent leaves the directory uncreated🤖 Generated with Claude Code