Repository navigation
Test rig fixes - #1704
Merged
Merged
Test rig fixes#1704
Conversation
mattiaswal
force-pushed
the
test-rig-fixes
branch
5 times, most recently
from
October 14, 2026 06:31
e148319 to
0f4179c
Compare
Same check as igmp_basic, but each DUT needs only one host data link and one mgmt link, so it maps onto rigs where DUTs have a single host-facing port. The receiver sits at the far end so the membership report has to cross two switches before the middle DUT prunes its own host port. Signed-off-by: Mattias Walström <[email protected]>
A single step waiting for five adjacencies could sit for 17 minutes and then fail without saying which pair never reached full. Signed-off-by: Mattias Walström <[email protected]>
Seen on the BPi-R3 test system: the full suite failed only here, with "RTNETLINK answers: Resource temporarily unavailable" from the MAC change. On a passthru macvlan the change is forwarded to the parent interface, and the kernel returned EAGAIN for it. The macvlan keeps its old MAC when that fails, and unchecked the step failed later on the lease. With check=True the command raises, and until() retries it. Signed-off-by: Mattias Walström <[email protected]>
Not needed, the case it covers is not a big risk. Signed-off-by: Mattias Walström <[email protected]>
mattiaswal
force-pushed
the
test-rig-fixes
branch
from
October 14, 2026 06:33
0f4179c to
42def34
Compare
rauc-installation-status already emits it, statd dropped it on the way into /system-state/software/installer. Signed-off-by: Mattias Walström <[email protected]>
Seen on the BPi-R3 rig: the installer went idle with "Installing failed." and the test still passed the wait step, only to trip on the boot order. Signed-off-by: Mattias Walström <[email protected]>
wkz
approved these changes
Oct 14, 2026
Comment on lines
+71
to
+81
| _, d1data = env.ltop.xlate("dut1", "data") | ||
| _, d1link = env.ltop.xlate("dut1", "link") | ||
| _, d2data = env.ltop.xlate("dut2", "data") | ||
| _, d2west = env.ltop.xlate("dut2", "west") | ||
| _, d2east = env.ltop.xlate("dut2", "east") | ||
| _, d3data = env.ltop.xlate("dut3", "data") | ||
| _, d3link = env.ltop.xlate("dut3", "link") | ||
|
|
||
| _, hsend = env.ltop.xlate("host", "data1") | ||
| _, hnojoin = env.ltop.xlate("host", "data2") | ||
| _, hreceive = env.ltop.xlate("host", "data3") |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fallout from running the full suite on the BPi-R3 test system.
a chain, so each needs only one data link and one mgmt link and it
maps onto rigs where DUTs have a single host-facing port.
waiting for all five could sit for 17 minutes and then fail without
saying which pair never reached full.
rig, "RTNETLINK answers: Resource temporarily unavailable" from the
host MAC change. On a passthru macvlan the change is forwarded to
the parent interface, and the kernel returned EAGAIN for it. The
macvlan keeps its old MAC when that fails, and unchecked the step
failed later on the lease. The change now runs with
check=Trueunder
until(), so it is retried and a persistent failure stops thetest at the MAC change.
Checklist
Tick relevant boxes, this PR is-a or has-a: