Skip to content

klish: Do not autocomplete nodes that do not pass a when expression - #1336

Merged
troglobit merged 1 commit into
mainfrom
klish-add-support-for-when
Dec 26, 2025
Merged

troglobit merged 1 commit into
mainfrom
klish-add-support-for-when

Conversation

@mattiaswal

@mattiaswal mattiaswal commented Dec 24, 2025 •

Copy link
Copy Markdown
Contributor

This is most noticeable in interface context

admin@infix-00-00-00:/config/interface/e1/> set type wifi
admin@infix-00-00-00:/config/interface/e1/> set Tab
bind-ni-name         bridge-port   container-network custom-phys-address         
description          enabled       ethernet

where you previously got all containers for all interface-types, now just wifi and ethernet (since it has configuration)

Big contributor for this: claude.ai ❤️

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

This is most noticeable in interface context

admin@infix-00-00-00:/config/interface/e1/> set type wifi
admin@infix-00-00-00:/config/interface/e1/> set
bind-ni-name         bridge-port   container-network custom-phys-address         description             enabled            ethernet

where you previously got *all* containers for all interface-types.
@mattiaswal
mattiaswal requested review from troglobit and wkz December 24, 2025 21:11
@mattiaswal
mattiaswal marked this pull request as ready for review December 24, 2025 21:11

@troglobit troglobit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 💯

@troglobit
troglobit merged commit 72a389a into main Dec 26, 2025
7 checks passed
@troglobit
troglobit deleted the klish-add-support-for-when branch December 26, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants