Support collection fixes and additions

[troglobit]

Description

• Extend support script to handle case where /var/lib/support exists and is owned by root
• Extract all use of sudo inside script in favor of letting the user decide
• Fix misplaced iitod.conf override for Styx DCP-SC-28p

Checklist

Tick relevant boxes, this PR is-a or has-a:

• Bugfix
  • Regression tests
  • ChangeLog updates (for next release)
• Feature
  • YANG model change => revision updated?
  • Regression tests added?
  • ChangeLog updates (for next release)
  • Documentation added?
• Test changes
  • Checked in changed Readme.adoc (make test-spec)
  • Added new test to group Readme.adoc and yaml file
• Code style update (formatting, renaming)
• Refactoring (please detail in commit messages)
• Build related changes
• Documentation content changes
  • ChangeLog updated (for major changes)
• Other (please describe): support script plugin

[wkz]

What do you think about having cmd_collect() do one initial check for sudo availability - if it is available, we re-exec the support script with sudo?

Then we don't have to think about it in any of the following commands. I.e., everything that follows can assume that the privileges it has is the maximum available.

[troglobit]

What do you think about having cmd_collect() do one initial check for sudo availability - if it is available, we re-exec the support script with sudo?

Then we don't have to think about it in any of the following commands. I.e., everything that follows can assume that the privileges it has is the maximum available.

It's sure easier for future extensions and additions, but I'd rather like to see it possible to run the script as a less privileged user without sudo access. (Also, giving a script full root access instead of per-command feels a bit unsafe to me.)

So I propose this instead:

  SUDO=""                                                                                                                                                 
  if [ "$(id -u)" -ne 0 ]; then                                                                                                                           
      if command -v sudo >/dev/null 2>&1 && sudo -n true 2>/dev/null; then                                                                                
          SUDO="sudo"                                                                                                                                     
      fi                                                                                                                                                  
  fi                                                                                                                                                      
  export SUDO 

That way our plugins can always rely on $SUDO being available to them, and users could get a subset of the information available to them. This also works for future users that may have to input sudo password.

[troglobit]

AFK we agreed that extracting sudo everywhere from within the script and instead letting the user decide the level of logs retrieved, calling with/without sudo.

[wkz]

Excellent! ✨