Repository navigation
docs(so): audit of the SO agent infrastructure - #645
Open
privatejoel wants to merge 1 commit into
Open
privatejoel wants to merge 1 commit into
privatejoel wants to merge 1 commit into
Conversation
The audit that the plan in #643 describes. Read only, at 931eb14. 84 mechanisms in five layers, 24 conflicts, a target model of 9 shared primitives grown from parts that already work, 30 small PRs in merge order, 12 owner decisions, and 122 defects (24 high). A verifier re-read 123 claims against the code; its corrections are in. The cards file holds the five layer reports as evidence. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the audit that the plan in #643 describes. It is stacked on #643. Merge #643 first. Docs only.
docs/SO_AGENT_INFRA_AUDIT.mdis the audit. It is read only, at931eb143.docs/SO_AGENT_INFRA_AUDIT_CARDS.mdis the evidence: one Q1 to Q18 card for each mechanism, and the five layer reports.Verdict. The owner is right. SO agent work runs on 84 mechanisms (49 from the plan, 35 found by the audit). They share almost nothing. On
mainthere are 6 trust models, 11 queue shapes, 2 staleness maps, 8 recipient resolvers and 8 paths that create an order.Findings that need attention now
tally_voucher_statedoes not have (_lib/tally-reconciler.js:325-329). It flags every exported voucher as missing. With fix(tally): the reconciler re-queues a voucher missing in Tally #632 and auto-fix on, every recent voucher is pushed to Tally again as a new voucher.inbound/email/parse.js:148).main, five of six SO events reach no person. When a Tally push gives up, nobody is told.Outputs
path:lineand a fix PR (section 8).Method. Five read-only layer auditors worked in parallel. The lead re-read every high claim in the code. Then a fresh verifier checked 123 claims against the code. It found 14 that were wrong or overstated, and all 14 are corrected (section 9). #643 also gets one correction: only
orders/[id].jsimports the order write gate.Deploy notes
None. This PR changes docs only. It has no migration and no env change. The migration numbers that the U-PRs name (271 to 274, plus 266 from #611) are proposals. Nothing reserves them until a PR builds them.
Tests
None needed, because no code changed. Every high defect, every conflict and every signal verdict was checked against
931eb143twice: once by the lead and once by the verifier. Section 9 lists what changed. Both files have no em or en dashes and no customer, person or part names. One code identifier contains a customer name, so the cards file calls it "a second legacy tenant header".Not covered
🤖 Generated with Claude Code