Generate a .bat launcher for command and multirun on Windows - #100
Open
soda0289 wants to merge 1 commit into
Open
Generate a .bat launcher for command and multirun on Windows#100soda0289 wants to merge 1 commit into
soda0289 wants to merge 1 commit into
Conversation
Windows can only execute files with extensions bat, exe or com. When launching a bash script a batch script must be generated that locates bash on windows using BASH_SH environment variable or using a provided toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows can only execute files with extensions
.bat,.exeor.com. When launching a bash script a batch script must be generated that locates bash on windows using BASH_SH environment variable or using a provided toolchain. This fixes multirun on windows since the current code just passes a bash script as executable which fails on windows.