Skip to content

controllers/crd: preserve strategy retry counter across failed-CR replace #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

controllers/crd: preserve strategy retry counter across failed-CR replace #537

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cef9f1
controllers/crd: preserve strategy retry counter across failed-CR rep…
SAY-5 Apr 20, 2026
72cf831
Merge branch 'master' into fix/strategy-retry-counter-preserved-on-re…
SAY-5 Jun 9, 2026
8e39579
Merge remote-tracking branch 'origin/master' into work
SAY-5 Aug 16, 2026
12320b9
Merge branch 'master' into fix/strategy-retry-counter-preserved-on-re…
SAY-5 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion controllers/providers/kubernetes/crd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ func ProcessCRDStrategy(kube dynamic.Interface, instanceGroup *v1alpha1.Instance
return false, errors.Wrap(err, "failed to discover active custom resources")
}

// didReplace tracks whether we deleted a failed/stale CR on this pass.
// When we replace, the retry counter must NOT be reset: the retry counter
// exists to bound how many times we replace a failing CR, and resetting
// it on every successful re-create produced an infinite loop (#317).
var didReplace bool
if len(activeResources) > 0 {

switch strings.ToLower(policy) {
Expand Down Expand Up @@ -132,6 +137,7 @@ func ProcessCRDStrategy(kube dynamic.Interface, instanceGroup *v1alpha1.Instance
return false, errors.Wrap(err, "failed to delete custom resource")
}
}
didReplace = true
}
if isRunning {
// finally, if an active resource is still running, requeue until it's done
Expand All @@ -152,7 +158,12 @@ func ProcessCRDStrategy(kube dynamic.Interface, instanceGroup *v1alpha1.Instance
}
} else {
log.Info("submitted custom resource", "instancegroup", instanceGroupNamespacedName)
status.SetStrategyRetryCount(0)
if !didReplace {
// First-time submission for this strategy attempt: safe to clear
// the retry counter. On replace we keep the accumulated count so
// the retry budget is actually enforced.
status.SetStrategyRetryCount(0)
}
}

// get created resource
Expand Down