feat(protocol): 7.15 release additions — hive signing (1614-1617), clearsign identity icons, thorchain denom, ripple memo, zcash

.circleci/config.yml

@@ -3,7 +3,7 @@ version: 2
 defaults: &defaults
     working_directory: ~/device-protocol
     docker:
-        - image: circleci/node
+        - image: cimg/node:20.11
 
 jobs:
     build:

.github/workflows/ci.yml

@@ -0,0 +1,50 @@
+name: Protocol CI
+
+on:
+  push:
+    branches: [master, up/release-protocol]
+  pull_request:
+    branches: [master, up/release-protocol]
+
+permissions:
+  contents: read
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - name: Checkout
+        uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6
+
+      - name: Install protobuf compiler
+        run: sudo apt-get update && sudo apt-get install -y protobuf-compiler
+
+      - name: Use Node.js 20
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: npm
+
+      - name: Install JavaScript generator dependencies
+        run: npm ci
+
+      - name: Verify install generated JavaScript bindings
+        run: |
+          test -s lib/messages_pb.js
+          test -s lib/messages-solana_pb.js
+          test -s lib/messages-zcash_pb.js
+
+      - name: Compile protocol descriptors
+        run: |
+          protoc --proto_path=. --include_imports \
+            --descriptor_set_out=/tmp/keepkey-device-protocol.pb \
+            types.proto messages.proto messages-binance.proto \
+            messages-cosmos.proto messages-eos.proto messages-ethereum.proto \
+            messages-hive.proto messages-mayachain.proto messages-nano.proto \
+            messages-osmosis.proto messages-ripple.proto messages-solana.proto \
+            messages-tendermint.proto messages-thorchain.proto messages-ton.proto \
+            messages-tron.proto messages-zcash.proto
+
+      - name: Check RC18 Zcash wire contract
+        run: python3 tools/check_zcash_contract.py

.github/workflows/copilot-review.yml

@@ -1,11 +1,15 @@
 name: Request Copilot Review
 
 on:
-  pull_request:
+  # This workflow never checks out or executes pull-request code. Using the
+  # base-repository context is therefore safe and is required for cross-fork
+  # PRs, whose pull_request GITHUB_TOKEN is always downgraded to read-only.
+  pull_request_target:
     types: [opened, reopened, ready_for_review, synchronize]
 
 jobs:
   request-copilot-review:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write

lib/messages-ripple_pb.d.ts

@@ -0,0 +1,179 @@
+// package: 
+// file: messages-ripple.proto
+
+import * as jspb from "google-protobuf";
+
+export class RippleGetAddress extends jspb.Message {
+  clearAddressNList(): void;
+  getAddressNList(): Array<number>;
+  setAddressNList(value: Array<number>): void;
+  addAddressN(value: number, index?: number): number;
+
+  hasShowDisplay(): boolean;
+  clearShowDisplay(): void;
+  getShowDisplay(): boolean | undefined;
+  setShowDisplay(value: boolean): void;
+
+  serializeBinary(): Uint8Array;
+  toObject(includeInstance?: boolean): RippleGetAddress.AsObject;
+  static toObject(includeInstance: boolean, msg: RippleGetAddress): RippleGetAddress.AsObject;
+  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+  static serializeBinaryToWriter(message: RippleGetAddress, writer: jspb.BinaryWriter): void;
+  static deserializeBinary(bytes: Uint8Array): RippleGetAddress;
+  static deserializeBinaryFromReader(message: RippleGetAddress, reader: jspb.BinaryReader): RippleGetAddress;
+}
+
+export namespace RippleGetAddress {
+  export type AsObject = {
+    addressNList: Array<number>,
+    showDisplay?: boolean,
+  }
+}
+
+export class RippleAddress extends jspb.Message {
+  hasAddress(): boolean;
+  clearAddress(): void;
+  getAddress(): string | undefined;
+  setAddress(value: string): void;
+
+  serializeBinary(): Uint8Array;
+  toObject(includeInstance?: boolean): RippleAddress.AsObject;
+  static toObject(includeInstance: boolean, msg: RippleAddress): RippleAddress.AsObject;
+  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+  static serializeBinaryToWriter(message: RippleAddress, writer: jspb.BinaryWriter): void;
+  static deserializeBinary(bytes: Uint8Array): RippleAddress;
+  static deserializeBinaryFromReader(message: RippleAddress, reader: jspb.BinaryReader): RippleAddress;
+}
+
+export namespace RippleAddress {
+  export type AsObject = {
+    address?: string,
+  }
+}
+
+export class RippleSignTx extends jspb.Message {
+  clearAddressNList(): void;
+  getAddressNList(): Array<number>;
+  setAddressNList(value: Array<number>): void;
+  addAddressN(value: number, index?: number): number;
+
+  hasFee(): boolean;
+  clearFee(): void;
+  getFee(): number | undefined;
+  setFee(value: number): void;
+
+  hasFlags(): boolean;
+  clearFlags(): void;
+  getFlags(): number | undefined;
+  setFlags(value: number): void;
+
+  hasSequence(): boolean;
+  clearSequence(): void;
+  getSequence(): number | undefined;
+  setSequence(value: number): void;
+
+  hasLastLedgerSequence(): boolean;
+  clearLastLedgerSequence(): void;
+  getLastLedgerSequence(): number | undefined;
+  setLastLedgerSequence(value: number): void;
+
+  hasPayment(): boolean;
+  clearPayment(): void;
+  getPayment(): RipplePayment | undefined;
+  setPayment(value?: RipplePayment): void;
+
+  hasMemo(): boolean;
+  clearMemo(): void;
+  getMemo(): string | undefined;
+  setMemo(value: string): void;
+
+  serializeBinary(): Uint8Array;
+  toObject(includeInstance?: boolean): RippleSignTx.AsObject;
+  static toObject(includeInstance: boolean, msg: RippleSignTx): RippleSignTx.AsObject;
+  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+  static serializeBinaryToWriter(message: RippleSignTx, writer: jspb.BinaryWriter): void;
+  static deserializeBinary(bytes: Uint8Array): RippleSignTx;
+  static deserializeBinaryFromReader(message: RippleSignTx, reader: jspb.BinaryReader): RippleSignTx;
+}
+
+export namespace RippleSignTx {
+  export type AsObject = {
+    addressNList: Array<number>,
+    fee?: number,
+    flags?: number,
+    sequence?: number,
+    lastLedgerSequence?: number,
+    payment?: RipplePayment.AsObject,
+    memo?: string,
+  }
+}
+
+export class RipplePayment extends jspb.Message {
+  hasAmount(): boolean;
+  clearAmount(): void;
+  getAmount(): number | undefined;
+  setAmount(value: number): void;
+
+  hasDestination(): boolean;
+  clearDestination(): void;
+  getDestination(): string | undefined;
+  setDestination(value: string): void;
+
+  hasDestinationTag(): boolean;
+  clearDestinationTag(): void;
+  getDestinationTag(): number | undefined;
+  setDestinationTag(value: number): void;
+
+  serializeBinary(): Uint8Array;
+  toObject(includeInstance?: boolean): RipplePayment.AsObject;
+  static toObject(includeInstance: boolean, msg: RipplePayment): RipplePayment.AsObject;
+  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+  static serializeBinaryToWriter(message: RipplePayment, writer: jspb.BinaryWriter): void;
+  static deserializeBinary(bytes: Uint8Array): RipplePayment;
+  static deserializeBinaryFromReader(message: RipplePayment, reader: jspb.BinaryReader): RipplePayment;
+}
+
+export namespace RipplePayment {
+  export type AsObject = {
+    amount?: number,
+    destination?: string,
+    destinationTag?: number,
+  }
+}
+
+export class RippleSignedTx extends jspb.Message {
+  hasSignature(): boolean;
+  clearSignature(): void;
+  getSignature(): Uint8Array | string;
+  getSignature_asU8(): Uint8Array;
+  getSignature_asB64(): string;
+  setSignature(value: Uint8Array | string): void;
+
+  hasSerializedTx(): boolean;
+  clearSerializedTx(): void;
+  getSerializedTx(): Uint8Array | string;
+  getSerializedTx_asU8(): Uint8Array;
+  getSerializedTx_asB64(): string;
+  setSerializedTx(value: Uint8Array | string): void;
+
+  serializeBinary(): Uint8Array;
+  toObject(includeInstance?: boolean): RippleSignedTx.AsObject;
+  static toObject(includeInstance: boolean, msg: RippleSignedTx): RippleSignedTx.AsObject;
+  static extensions: {[key: number]: jspb.ExtensionFieldInfo<jspb.Message>};
+  static extensionsBinary: {[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>};
+  static serializeBinaryToWriter(message: RippleSignedTx, writer: jspb.BinaryWriter): void;
+  static deserializeBinary(bytes: Uint8Array): RippleSignedTx;
+  static deserializeBinaryFromReader(message: RippleSignedTx, reader: jspb.BinaryReader): RippleSignedTx;
+}
+
+export namespace RippleSignedTx {
+  export type AsObject = {
+    signature: Uint8Array | string,
+    serializedTx: Uint8Array | string,
+  }
+}
+