Skip to content

needs cargo updated to parse latest ed2018 crates #141

Closed

Description

@matthiaskrgr

The latest cargo shipped by rust nightly has the edition = "2018" feature stabilized but cargo outdated still relies on cargo 0.28 which does not have the feature stabilized.

Thus cargo outdated fails to parse Cargo.toml's which use the ed2018 feature without the feature gate.

 error: failed to parse manifest at `/home/matthias/vcs/github/cargo-cache/Cargo.toml`
Caused by:
  editions are unstable
Caused by:
  feature `edition` is required
consider adding `cargo-features = ["edition"]` to the manifest

Activity

  1. joelgallant commented on Sep 28, 2018

    @joelgallant
    Contributor

    This is due to the Manifest struct not holding on to cargo-features, so the TempProject does not write them to its Cargo.toml (causing the parsing of it later on to fail).

    joelgallant@6930e6a (like rust-lang/rls#1045)

    This patch gets some of the way there, but the TempProject thing requires more work. I might guess that the author will just wait for this to stabilize instead of adding work for themselves, but carrying over cargo-features seems worthwhile nonetheless.

  2. BlinkyStitt commented on Nov 7, 2018

    @BlinkyStitt

    I just ran into this. Worked around it by commenting out edition = "2018" in my Cargo.toml when I need to run cargo outdated.

  3. svenstaro commented on Dec 3, 2018

    @svenstaro

    Isn't this going to fix itself once the next rust is released which will bring edition 2018 to stable?

  4. aldanor commented on Dec 6, 2018

    @aldanor

    Nope; 2018 is out today, this still fails on 1.31 stable.

  5. joelgallant commented on Dec 6, 2018

    @joelgallant
    Contributor

    Is because it uses the API of an older version of cargo

  6. svenstaro commented on Dec 9, 2018

    @svenstaro

    Should be fixed by #145.

  7. est31 commented on Dec 22, 2018

    @est31
    Contributor

    Particularly sad for me because I just updated my copy of cargo-outdated from an ancient version that didn't have the edition feature gating yet to the broken one... I guess I'll use @bbigras 's workaround for the time being.

  8. kornelski commented on Dec 26, 2018

    @kornelski
    Collaborator

    This is fixed. It's waiting for crates.io release, but for now you can also install it from git.

  9. dbrgn commented on Jan 7, 2019

    @dbrgn

    Any chance for a crates.io release? 🙂

  10. kornelski commented on Jan 7, 2019

    @kornelski
    Collaborator

    About the release, please see #153 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions