You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
needs cargo updated to parse latest ed2018 crates #141
The latest cargo shipped by rust nightly has the edition = "2018" feature stabilized but cargo outdated still relies on cargo 0.28 which does not have the feature stabilized.
Thus cargo outdated fails to parse Cargo.toml's which use the ed2018 feature without the feature gate.
error: failed to parse manifest at `/home/matthias/vcs/github/cargo-cache/Cargo.toml`
Caused by:
editions are unstable
Caused by:
feature `edition` is required
consider adding `cargo-features = ["edition"]` to the manifest
Reacted by Joel Gallant, Ivan Kozik, g, Chevdor, 0e4ef622, Bryan Stitt, Sergei Shulepov, David James, hcpl, Nagy Tibor and 16 more
This is due to the Manifest struct not holding on to cargo-features, so the TempProject does not write them to its Cargo.toml (causing the parsing of it later on to fail).
This patch gets some of the way there, but the TempProject thing requires more work. I might guess that the author will just wait for this to stabilize instead of adding work for themselves, but carrying over cargo-features seems worthwhile nonetheless.
Nope; 2018 is out today, this still fails on 1.31 stable.
Reacted by Jon Gjengset, Thomas Gideon, Friedrich von Gellhorn, Aluísio Augusto Silva Gonçalves, Hirokazu Hata, evnix, O01eg, Kornel, Sujit Joshi and jjpe
Particularly sad for me because I just updated my copy of cargo-outdated from an ancient version that didn't have the edition feature gating yet to the broken one... I guess I'll use @bbigras 's workaround for the time being.
Activity
joelgallant commentedon Sep 28, 2018
This is due to the
Manifeststruct not holding on tocargo-features, so the TempProject does not write them to itsCargo.toml(causing the parsing of it later on to fail).joelgallant@6930e6a (like rust-lang/rls#1045)
This patch gets some of the way there, but the TempProject thing requires more work. I might guess that the author will just wait for this to stabilize instead of adding work for themselves, but carrying over
cargo-featuresseems worthwhile nonetheless.BlinkyStitt commentedon Nov 7, 2018
I just ran into this. Worked around it by commenting out
edition = "2018"in my Cargo.toml when I need to runcargo outdated.svenstaro commentedon Dec 3, 2018
Isn't this going to fix itself once the next rust is released which will bring edition 2018 to stable?
aldanor commentedon Dec 6, 2018
Nope; 2018 is out today, this still fails on 1.31 stable.
joelgallant commentedon Dec 6, 2018
Is because it uses the API of an older version of cargo
svenstaro commentedon Dec 9, 2018
Should be fixed by #145.
est31 commentedon Dec 22, 2018
Particularly sad for me because I just updated my copy of cargo-outdated from an ancient version that didn't have the edition feature gating yet to the broken one... I guess I'll use @bbigras 's workaround for the time being.
kornelski commentedon Dec 26, 2018
This is fixed. It's waiting for crates.io release, but for now you can also install it from git.
dbrgn commentedon Jan 7, 2019
Any chance for a crates.io release? 🙂
kornelski commentedon Jan 7, 2019
About the release, please see #153 (comment)