Repository navigation
chore: require an engineering approval on every change - #4
Open
Alex (Alexkuva) wants to merge 1 commit into
Open
Alex (Alexkuva) wants to merge 1 commit into
Alex (Alexkuva) wants to merge 1 commit into
Conversation
The default-branch ruleset already requires a review from a code owner, but without a CODEOWNERS file that rule applied to nothing: any approval from an account with write access counted. That included GitHub Actions, which the repository allows to approve pull requests, and the apps installed across the organization with write access to pull requests. .github/CODEOWNERS makes @kaitencloud/engineering the owner of every path, so a pull request now needs the approval of a member of that team. An app or a workflow's token cannot belong to a team, and the author cannot approve their own pull request, so the approval has to come from another engineer. Signed-off-by: Alexandre Bergere <[email protected]>
fuzcap
approved these changes
Oct 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/CODEOWNERS, which makes@kaitencloud/engineeringthe owner of every path.The
default-branchruleset already requires a review from a code owner, but without this filethe rule applied to nothing: any approval from an account with write access counted. That
included GitHub Actions, which this repository allows to approve pull requests, and the apps
installed across the organization with write access to pull requests.
With it, every pull request needs the approval of a member of
@kaitencloud/engineering. An appor a workflow's token cannot belong to a team, and an author cannot approve their own pull
request, so the approval has to come from another engineer.
GitHub validates the file (
GET /repos/{owner}/{repo}/codeowners/errors): no errors, the teamis known and has write access.
The rule applies from the pull request after this one: GitHub reads
CODEOWNERSfrom the basebranch.
🤖 Generated with Claude Code · ✅ Tested and approved by Alex (@Alexkuva), maintainer