fix(ui): wait for schedule deletion redirect in live test - #2879
Open
Dragonzz27 wants to merge 1 commit into
Open
Dragonzz27 wants to merge 1 commit into
Dragonzz27 wants to merge 1 commit into
Conversation
Signed-off-by: Dragonzz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2850.
Summary
Wait for the redirect to the schedules list after deletion, then assert that the deleted schedule is absent. Do not inspect or click controls on the detail page that navigation is unmounting. Production navigation and retained-history behavior are unchanged.
Verification
From
ui/:yarn typecheck— passed.yarn exec eslint playwright/live/schedules.spec.ts --max-warnings 0— passed.yarn test— 524 tests passed.Backlink detaches during navigation and times out. The same browser probe with the redirect assertion passes; both that probe and the existing schedule lifecycle test passed (2/2).The live cluster suite was not run: this local environment has no configured kagent cluster. The browser probe verifies the UI navigation race, not controller persistence. Existing retained-history coverage in the fixture suite is unchanged.
Implemented with AI assistance; all changes were reviewed and validated locally.