fix(ui): isolate theme hook from refreshable provider - #2878
Merged
Charlesthebird merged 1 commit intoSep 21, 2026
Merged
Conversation
Signed-off-by: Dragonzz <[email protected]>
Charlesthebird
approved these changes
Sep 21, 2026
Charlesthebird
enabled auto-merge
September 21, 2026 15:10
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2872.
Summary
useThemeModeinto a non-component module, leavingthemeMode.tsxwith only its provider export.Verification
From
ui/:yarn exec eslint src/theme --max-warnings 0— passes; the original module fails this check withreact-refresh/only-export-components.yarn test— 528 tests passed.yarn typecheckandyarn build— passed.yarn lint— no errors; 7 unrelated existing warnings remain.yarn test:pw theme-contrast.spec.ts app-shell --project=chromium— all 12 Chromium cases passed in the combined browser run.Firefox was also attempted, including a single-worker retry, but the local Firefox process exits before running tests with
Could not find profile folder. No Firefox pass is claimed.Implemented with AI assistance; all changes were reviewed and validated locally.