Skip to content

fix(python): run basic ADK sample through kagent-adk - #2832

Open
tryambak2019 wants to merge 2 commits into
kagent-dev:mainfrom
tryambak2019:fix/2689-adk-sample-startup
Open

tryambak2019 wants to merge 2 commits into
kagent-dev:mainfrom
tryambak2019:fix/2689-adk-sample-startup

Conversation

@tryambak2019

Copy link
Copy Markdown
Contributor

Summary

Fix the ADK basic sample container command and validate its supported runtime-loading path.

Implemented

  • Run the sample through kagent-adk run basic from its package directory.
  • Add CI coverage that loads the real root_agent through the ADK CLI with Uvicorn mocked.
  • Preserve Google ADK session semantics; the test uses the CLI's explicit local in-memory mode.

Validation

  • Focused CLI regression test passed.
  • make -C python test passed.
  • Ruff lint, format, and uv lock --check passed.
  • Docker build is blocked before execution because the default external kagent-adk:latest base image is not published in GHCR.

#2689 Series

Related to #2689. This PR does not close it.

@tryambak2019
tryambak2019 requested a review from a team as a code owner September 16, 2026 00:11
@github-actions github-actions Bot added the bug Something isn't working label Sep 16, 2026

@supreme-gg-gg supreme-gg-gg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tryambak2019 Your "series" of PR is very difficult to review, can you put all Python changes into one single PR since they're related to the same issue. Especially that I found a few possible issues with pytest and health checks that will become apparent once they're combined. This also reduces overhead for merge conflicts and CI runs. I'll take another look once that's done

For the docs PR #2821, if you make its doc changes independent of your new python changes, then I think it can stay separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants