fix(python): run basic ADK sample through kagent-adk - #2832
Open
tryambak2019 wants to merge 2 commits into
Open
tryambak2019 wants to merge 2 commits into
tryambak2019 wants to merge 2 commits into
Conversation
Signed-off-by: tryambak2019 <[email protected]>
Signed-off-by: tryambak2019 <[email protected]>
supreme-gg-gg
requested changes
Sep 18, 2026
supreme-gg-gg
left a comment
Contributor
There was a problem hiding this comment.
@tryambak2019 Your "series" of PR is very difficult to review, can you put all Python changes into one single PR since they're related to the same issue. Especially that I found a few possible issues with pytest and health checks that will become apparent once they're combined. This also reduces overhead for merge conflicts and CI runs. I'll take another look once that's done
For the docs PR #2821, if you make its doc changes independent of your new python changes, then I think it can stay separate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the ADK basic sample container command and validate its supported runtime-loading path.
Implemented
kagent-adk run basicfrom its package directory.root_agentthrough the ADK CLI with Uvicorn mocked.Validation
make -C python testpassed.uv lock --checkpassed.kagent-adk:latestbase image is not published in GHCR.#2689 Series
Related to #2689. This PR does not close it.