Repository navigation
docs: only MCP and web-api send Retry-After on a 503 - #642
Merged
Merged
Conversation
Codex on #622: the collector door's refused connection reaches the shared server's generic 503 with no Retry-After, so DECISIONS promised more than it does. The Go collector retries a 5xx on its own backoff and reads Retry-After only on a retryable 4xx, so the promise is narrowed rather than the door changed. Co-Authored-By: Claude Opus 5.5 <[email protected]>
jthingelstad
marked this pull request as ready for review
October 21, 2026 08:47
jthingelstad
enabled auto-merge (rebase)
October 21, 2026 08:47
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Deployed to production 2026-10-21T09:20:05Z (2026-10-21 04:20:05 CDT).
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers the Codex finding on #622 (P2,
docs/DECISIONS.md:251). DECISIONS promised that every door pool answers a connection it cannot have with 503 andRetry-After, but the collector door does not.What the collector door does now.
services/collector/src/handler.mjslets a refuseddb.connect()reach the shared server's generic 503 (packages/http/src/server.mjs), which carries no header.Why narrow the promise, not change the door. The Go collector retries any 5xx on its own backoff. It reads
Retry-Afteronly on a 4xx the hub names retryable (elixir-mcp-collector/internal/v2/v2.go,submitWithRetry), so a header on its 503 would change nothing it does.What changes. DECISIONS and ENGINEERING now name the two doors that send
Retry-After: MCP and web-api. A short note records the finding. Docs only; no code or contract moves.npm run verifygreen.e2e-needed.shprints false.🤖 Generated with Claude Code