Repository navigation
docs: the deploy order names every phase; #640's note is its own - #641
Merged
Merged
Conversation
The order in infra/AGENTS.md and the ship skill left out the first migrations (--create) and the public statistics snapshot, which stops a platform deploy when it fails (Codex on #637). #640 had added its measurements and the delete handling to #639's merged note; they move to a note of their own, since a merged note is history. Co-Authored-By: Claude Opus 5.5 <[email protected]>
jthingelstad
marked this pull request as ready for review
October 21, 2026 08:21
jthingelstad
enabled auto-merge (rebase)
October 21, 2026 08:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Deployed to production 2026-10-21T08:29:37Z (2026-10-21 03:29:37 CDT).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR answers the Codex finding on #637 and fixes a notes-rule slip in #640. It changes docs only.
The documented deploy order in
infra/AGENTS.mdand the ship skill was missing two phases,first-migrationsandpublic-stats(Codex P2 on deploy: an ordered phase list, timed, with an endpoint grant check #637):first-migrationsruns only on--create.public-statsruns on the platform lane, and a failed snapshot stops the deploy.The
infra/AGENTS.mdorder now also spells out what the migrate step covers: push, the seed check when asked, apply.The notes rule. deploy: a key S3 keeps on delete is never counted as removed #640 appended its measurements and its delete handling to deploy: the site publishes only what changed #639's note, but a merged note is history (
docs/notes/README.md). This PR restores deploy: the site publishes only what changed #639's note to its text as merged. That content now lives in its own note,docs/notes/2026-10-21-site-publish-follow-ups.md, which also carries the before, first-run and steady-state phase timings.Checks:
npm run verifypasses.e2e-neededreports false.🤖 Generated with Claude Code