Skip to content

Fix/1920 jsoneditor index0 - #2640

Open
shiv07-blip wants to merge 4 commits into
json-schema-org:mainfrom
shiv07-blip:fix/1920-jsoneditor-index0
Open

shiv07-blip wants to merge 4 commits into
json-schema-org:mainfrom
shiv07-blip:fix/1920-jsoneditor-index0

Conversation

@shiv07-blip

@shiv07-blip shiv07-blip commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bugfix - corrects an early-return check in JsonEditor that mishandled a code block found at index 0.

Issue Number:
Closes #1920

Screenshots/videos:

N/A - this is a logic-level fix with no visible UI change. The behaviour is covered by a new Cypress component test.

If relevant, did you update the documentation?

Not needed - no public API or docs behaviour changed.

Summary
The JsonEditor uses indexOf to locate the code block inside the markdown. That returns 0 when the block is at the start, and the old check if (!positionOfCodeInFullMarkdown) treated 0 as "not found", so the block was never handled. I replaced it with an explicit check for undefined and -1.
I also added a test in cypress/components/JsonEditor.cy.tsx that places the code block at index 0 and checks that the caption does not get the mb-10 class.
Tested with yarn lint, yarn typecheck, and the JsonEditor Cypress spec (39 passing).

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview ea0d6fd

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5158a0a) to head (ea0d6fd).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2640   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          695       737   +42     
  Branches       215       229   +14     
=========================================
+ Hits           695       737   +42     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

1 active deployment
Preview — ea0d6fdc Deployed Nov 10, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to review

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Falsy check incorrectly treats index 0 as "not found" in JsonEditor component

1 participant