Repository navigation
Fix/1920 jsoneditor index0 - #2640
Open
shiv07-blip wants to merge 4 commits into
Open
shiv07-blip wants to merge 4 commits into
shiv07-blip wants to merge 4 commits into
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 695 737 +42
Branches 215 229 +14
=========================================
+ Hits 695 737 +42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix - corrects an early-return check in
JsonEditorthat mishandled a code block found at index0.Issue Number:
Closes #1920
Screenshots/videos:
N/A - this is a logic-level fix with no visible UI change. The behaviour is covered by a new Cypress component test.
If relevant, did you update the documentation?
Not needed - no public API or docs behaviour changed.
Summary
The JsonEditor uses indexOf to locate the code block inside the markdown. That returns 0 when the block is at the start, and the old check if (!positionOfCodeInFullMarkdown) treated 0 as "not found", so the block was never handled. I replaced it with an explicit check for undefined and -1.
I also added a test in cypress/components/JsonEditor.cy.tsx that places the code block at index 0 and checks that the caption does not get the mb-10 class.
Tested with yarn lint, yarn typecheck, and the JsonEditor Cypress spec (39 passing).
Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.