Repository navigation
Conversation
5 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented gradient example currently passes unsupported plain stop objects and uses an invalid callback-ref pattern. This adds declarative stop composition and a direct resource-binding API for both gradient components.
Stop/StopProps/RefStop; support prop updates/resets, keyed reorder, insertion/removal, fragments, and locally updated memoized children.Two.Stop[]arrays. Array stops precede JSX stops when combined. Shape children retain the surrounding scene parent.Validation:
npm run lint,npx tsc -b,npm run build:lib, andnpm run build:docspassed. Docs retain the existing large-chunk advisory.tests/browser/gradients.htmlin the in-app browser: linear/radial gradients passed on real SVG, Canvas, and WebGL, checking rendered colors (pixel samples for raster renderers), keyed updates, and cleanup.Fixes #31