Repository navigation
Conversation
…JSON Signed-off-by: Sai Asish Y <[email protected]>
Collaborator
|
This was fixed on #447 and already released as a new version. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447.
peek_header/1andpeek_claims/1are spec'd as{:ok, claims} | {:error, error_reason}, but they bindJOSE.json_module().decode/1directly in thewith. On OTP's:jsonbackend that call raises on a segment that base64-decodes to invalid JSON (e.g.Joken.peek_claims("invalid.jwt.token")), so the exception escapes theelseclause instead of becoming{:error, :token_malformed}:This wraps the JSON decode in a small
safe_json_decode/1helper that returns:erroron a decode exception, matching the tagged{:decode64, _}handling already in these functions. The happy path is unchanged and still does a single decode, sopeek_*stays fast (per the note in #447) while honouring its{:error, :token_malformed}contract for malformed input.