Conversation
johanrd
force-pushed
the
test/string-root-element-without-dom
branch
from
September 16, 2026 08:58
90df45a to
bc67e14
Compare
johanrd
changed the title
johanrd
force-pushed
the
test/string-root-element-without-dom
branch
2 times, most recently
from
September 16, 2026 09:05
cbf5037 to
3afca11
Compare
… is false With isBrowser: false, OutletView.appendTo hands a string rootElement straight to the element builder, which fails on the first insert with `TypeError: parent.insertBefore is not a function`. Component.appendTo asserts in this case; this test expects the same assertion. In production this happens in browsers whose global fails one of the identity checks in has-dom.ts, so isBrowser defaults to false while the rootElement is still the default 'body' selector. Cowritten by Claude
johanrd
force-pushed
the
test/string-root-element-without-dom
branch
from
September 16, 2026 09:39
3afca11 to
b6eac5d
Compare
johanrd
changed the title
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing test, no fix.
With
isBrowser: false,OutletView.appendTohands a stringrootElementstraight to the element builder, which fails on the first insert withTypeError: parent.insertBefore is not a function.Component.appendToasserts in this case; the test expects the same assertion.In production we see this (
e.insertBeforein minified builds) from browsers whose global fails one of the identity checks inhas-dom.ts, soisBrowserdefaults to false whilerootElementis still the default'body'selector. Context: emberjs/rfcs#1178 and emberjs#21348 would remove thehasDOMsplit.steps to repro faling test
pnpm start