Repository navigation
chore: rewrite bundle-size with valof, and budget each import by what it adds - #69
Merged
Merged
Conversation
…unctions with function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Each bundle was compared with the core's budget plus its increment, so it passed by using the core's unused budget. Every byte the core grew took a byte from every other bundle's room.
The production checks searched the bundle for three development strings and
Number.isNaN. Renaming a function or a message silenced them, and new development code went unchecked.What changed
added by Enum +474 B / +640 B).DevCodeKeptErrorfails a bundle whose source readsNODE_ENVwhile production and development minify to the same size.AddsNothingErrorfails a bundle that adds no library code to the base.--jsonkeys and shape, soreplace-bundle-size-claimsreads the same numbers.scripts/bundle-size.tsintoscripts/bundle-size/, modelling the bundles, the measurements and the report as valof values.pipe,flowandtapinscripts/shared/pipe, with type tests generated for every overload.flowcan end in a sink such asGenAwait, whichResult.gentakes withyield*.#valof, and check them againstsrcbefore each release.