Add support for LW, W and L to unix cron tab expressions - #671
Open
austek wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@jmrozanec could I get a review on this PR? |
W means "nearest weekday to the nth day of month" and only OnDayOfMonthValueGenerator implements it. Allowing it on day of week let expressions such as "0 0 * * 5W" parse while never producing an execution, with CronDescriptor silently dropping the modifier. Quartz and Spring53 omit W from day of week for the same reason. Add Issue670Test covering parsing, scheduling and description of L, L-n, nW, LW and nL on the unix definition, including a guard that W stays rejected on day of week, and add the unix to quartz mapping direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for LW, W and L to unix cron tab expressions
fixes #670