Split demo screenshots by MediaWiki version, add version header - #79
Merged
Conversation
hack/demo/demo.sh now reads MW_VERSION (default 1.43) to pick the mediawiki Docker image tag and save captures to docs/screenshots-$MW_VERSION instead of a single docs/screenshots, so screenshots from different MediaWiki versions don't overwrite each other — useful for checking whether a bug is specific to one version (as with issue #60). Existing captures moved to docs/screenshots-1.43 (they were already against that image), and docs/screenshots-1.45 was added by running `MW_VERSION=1.45 make screenshots`. Every demo page now also opens with a "SimpleMathJax <version>, MediaWiki {{CURRENTVERSION}}" line, so a screenshot is self-describing about what it was captured against without cross-referencing the directory name. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to closing #60: to make it easy to check whether a bug is specific to one MediaWiki version,
hack/demo/demo.shnow readsMW_VERSION(default1.43) to pick themediawikiDocker image tag and save captures todocs/screenshots-$MW_VERSIONinstead of a singledocs/screenshots.docs/screenshots-1.43(unchanged target, just renamed).docs/screenshots-1.45added by runningMW_VERSION=1.45 make screenshots— this is also the reproduction evidence behind closing MathJax error with MediaWiki 1.45 #60 (no error, renders correctly).SimpleMathJax <version>, MediaWiki {{CURRENTVERSION}}line, so a screenshot alone shows what it was captured against, without cross-referencing the directory name.MakefileandAGENTS.mdupdated to documentMW_VERSION.Testing
docs/screenshots-1.43anddocs/screenshots-1.45; spot-checked bothscreenshot-default01.pngs show the correct MediaWiki version (1.43.9 / 1.45.4) and matching SimpleMathJax version (1.0.1) in the header line.bash -n hack/demo/demo.shpasses.🤖 Generated with Claude Code