release workflow: fix mathjax.tar path, add manual retry trigger - #78
Merged
Conversation
git archive -o ../mathjax.tar was run from inside resources/MathJax, so it wrote to resources/mathjax.tar instead of the repo root, and the following `tar -Af base.tar mathjax.tar` couldn't find it. This broke the "Create GitHub release" step in the run triggered by 1.0.1 (https://github.com/jmnote/SimpleMathJax/actions/runs/34053829578), exit code 2, no release created. Write both archives to an absolute path captured before the `cd` instead. Also add a workflow_dispatch trigger, so a release can be retried by hand after a workflow bug like this one without a throwaway version bump; the existing "gh release view" check still skips it if the tag's release already exists. Verified by running the same steps against a detached worktree of main: the resulting SimpleMathJax-1.0.1-with-mathjax.tar.gz (6.2M) contains resources/MathJax/tex-chtml.js and extension.json at the expected paths. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v1.0.1release run (triggered by #77) failed at the "Create GitHub release" step: https://github.com/jmnote/SimpleMathJax/actions/runs/34053829578git archive ... -o ../mathjax.tarran from inside a( cd resources/MathJax && ... )subshell, so../mathjax.tarresolved toresources/mathjax.tar, not the repo root where the followingtar -Af base.tar mathjax.tarlooked for it. Fixed by writing both archives to an absolute path captured before thecd.Since
extension.json's version (1.0.1) didn't change again after that failed run, the push-triggered "version changed" check would skip re-running the release step even after this fix merges. Added aworkflow_dispatchtrigger so the release can be retried by hand —github.event.beforeis empty on a manual run, so the version-changed check always treats it as changed, and the existinggh release viewguard still skips it if that tag's release already exists.Testing
main:SimpleMathJax-1.0.1-with-mathjax.tar.gz(6.2M) now builds successfully and containsresources/MathJax/tex-chtml.jsandextension.jsonat the expected paths.Follow-up
After this merges, the
v1.0.1release needs to be triggered manually (gh workflow run release.ymlor the Actions tab's "Run workflow" button), since the version didn't change again in this PR.🤖 Generated with Claude Code