Skip to content

Update demo page title and screenshots - #76

Merged
jmnote merged 1 commit into
mainfrom
demo-page-title
Sep 6, 2026
Merged

Update demo page title and screenshots#76
jmnote merged 1 commit into
mainfrom
demo-page-title

Conversation

@jmnote

@jmnote jmnote commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • centralize the demo wiki page title as PAGE_TITLE
  • URL-encode the title used by screenshot routes
  • show demo source as wikitext and regenerate screenshots

Tests

  • make checks
  • bash -n hack/demo/demo.sh hack/local-mathjax.sh
  • node --check hack/demo/screenshot.mjs
  • parsed every demo settings/examples entry

@jmnote
jmnote merged commit 27dcfa1 into main Sep 6, 2026
2 checks passed
@jmnote
jmnote deleted the demo-page-title branch September 6, 2026 18:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e8fb938db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread hack/demo/demo.sh
DATA="$PWD/hack/demo/temp"
DOCKER_USER=33:33
PASS=demo12345678
PAGE_TITLE=SimpleMathJax

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the standalone screenshot URL default

When screenshot.mjs runs with URL unset, its fallback at hack/demo/screenshot.mjs:37 still opens /index.php/Demo, while up() now seeds only the SimpleMathJax page. The script therefore silently captures MediaWiki's missing-page view instead of the demo; update or remove that fallback when changing PAGE_TITLE.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant