Repository navigation
fix(hooks): avoid directory-only harness reminders - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script such as
python3 /tmp/codex-harness-audit/audit_parser.pypreviously triggered the Ringer reminder because a parent directory contained “harness”. Restrict the heuristic to the executed script basename and its argument boundary, including extension-bearing directory cases. Provider matching, advisory inline authorization, active-run suppression, edit counters and dedupe remain unchanged. Arbitrary heredocs/provider strings remain outside this narrow lexical fix.Validation: all12 focused nudge tests pass using isolated temporary HOME/RINGER_HOME. Nine benign-directory negative subcases fail against the old hook. Independent gpt-6-astra/high review is CLEAN after correcting an extension-directory boundary finding; the reviewer separately ran12 tests and1,680 regex cases. AST comparison confirms HARNESS_RE is the sole production change. No provider/model trials or installed state used by tests. Existing CI runs normally.
Reviewed hook SHA25663198fba46f8f774415dc25fe0e3389ec98f9ca4368bde7bb0f96de53d33f988 and test SHA2568671e887daf19b30fe5491d606b285584e7bfcba97a87070fc12cf10287443f5. Rollback is an ordinary revert of this commit; no hook definition/trust or permissions change.