Repository navigation
Fix worker cleanup and preserve completion evidence - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ringer could kill an OpenCode wrapper at timeout while leaving its separate-session server alive. This patch captures owned descendant groups before teardown and cleans them during timeout and runner shutdown, with regression coverage for a subsequent fresh job and unrelated-process survival.
It also cleans cancelled verifier processes, preserves valid JSON while redacting escaped and numeric credentials, ignores invalid token counts, retains billed step costs before engine-down returns, and records worker terminal status separately from executed artifact checks. Artifact-primary PASS semantics are preserved.
Validation: 417 tests passed under both Python 3.14 and the deployed Python 3.12 runtime. Independent adversarial review found no blocking defect in the final source. An unmodified canonical helper with local fake processes reproduced the original orphan and verified the fix; no real-provider completion is claimed by these tests.
This PR targets Jeff’s deployed
jeffbranch. The separately reviewed local helper startup fix and GLM variant configuration will be installed with rollback copies; they are outside this repository diff.