Skip to content

test(calendar): isolate providers and selection state - #97

Merged
jdylanmc merged 5 commits into
pocketfrom
chore/calendar-provider-fixtures
Oct 4, 2026
Merged

jdylanmc merged 5 commits into
pocketfrom
chore/calendar-provider-fixtures

Conversation

@jdylanmc

@jdylanmc jdylanmc commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Scope: #75 Calendar component isolation

Existing PR97, related #18; no issue closure. Explicit Calendar service, owned Defaults selection key and initial date enable synthetic-provider tests without fixture access to personal Calendar data, OS grants or real reminder mutations. Production shared singleton retains its real EventKit provider, selection key, observer and initial reload.

Intentional coupled fixes

Publish initial authorization state before awaiting provider access, resolve initial lists before date/selection operations, compare selected ID membership rather than counts, and prevent unavailable nonempty explicit selections becoming the providers empty-ID/all-calendar wildcard. Existing deliberate empty-selection fallback and error logging remain. Overlapping async response ordering is not addressed.

Acceptance evidence

Criterion Current evidence
Inert explicit provider/selection/date seam Met: Synthetic construction and owned-suite cases; no real provider used by fixtures
Deterministic authorization and bounded selection semantics Met: Regression-backed immediate authorization and first/stale/unavailable selection cases
Isolated regression coverage Met: All 18 Calendar cases retained and passing, including query, completion, errors and cleanup
Production wiring and honest limits Met: Original implementation patch unchanged after rebase; coverage document distinguishes component, live EventKit, normal XCTest host, UI and whole-profile scope
Reviewed, current delivery Met: changelog, full local validation, independent whole-deliverable Roast without significant findings, all fresh hosted gates, accepted Shepherd custody and verified non-draft promotion

Current candidate and validation

Head4fff039f5a62249c7ac84466c5cb0c124b2c9a06 on current pocket38074c12b3eeeb0feb2e2ea79c905fdfd3ef2998. Range-diff confirms original implementation patch is identical; the follow-up adds the scoped Unreleased changelog and corrects a stale Calendar Settings coverage entry while preserving Settings95 evidence.

Current local evidence: app build and all206 tests pass (18 Calendar); 69 helper tests; 170 workflow contracts; 22 PR-policy tests; 226 Python tests. App/helper lint pass their unchanged non-strict gates with recorded warnings; no warnings suppressed. The missing YAML dependency was restored through exact-lockfile npm ci only after the actual missing-dependency failure. App validation used isolated build output; the original running app/process/executable stayed unchanged.

Independent whole-deliverable Roast completed for head4fff039 against base38074c12, with no significant findings. Requirements and worktrees/SOLID/testing/laziness standards were covered; the reviewer independently inspected source, the full XCTest result bundle and supporting logs. Same-session Shepherd has taken custody after an actual provider/source/target observation. At 2026-09-28T22:38:50Z, all current-head checks passed, source/target still matched the reviewed pair, and GitHub promotion was read back as isDraft=false. Ready for human signoff at that snapshot; Shepherd continues observing and invalidates readiness on material source/target/review/check changes. Ship/Shepherd do not merge or enable auto-merge.

No new feature, real Calendar/account operation, native UI proof, whole-profile isolation, app installation/replacement, privacy change, release/signing/tag/asset change or broader #75 closure is claimed.

Inject the existing calendar provider, an owned Defaults selection key and initial date without changing production singleton startup. Exercise 18 synthetic-provider cases without personal events, OS grants or real reminder mutations.

Fix deferred authorization status writes and selection broadening before list load or with stale IDs. Preserve the existing empty-selection fallback and route every event refresh through the same selection checks.

Refs #75, #18
Document the Calendar provider fixtures and selection fixes in Unreleased.\nKeep Settings pane and whole-app isolation limits explicit.\n\nRefs #75, #18, PR #97
@jdylanmc
jdylanmc merged commit 84f0678 into pocket Oct 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant