Repository navigation
test(calendar): isolate providers and selection state - #97
Merged
Merged
Conversation
This was referenced Sep 28, 2026
Inject the existing calendar provider, an owned Defaults selection key and initial date without changing production singleton startup. Exercise 18 synthetic-provider cases without personal events, OS grants or real reminder mutations. Fix deferred authorization status writes and selection broadening before list load or with stale IDs. Preserve the existing empty-selection fallback and route every event refresh through the same selection checks. Refs #75, #18
jdylanmc
force-pushed
the
chore/calendar-provider-fixtures
branch
from
September 28, 2026 21:47
30fda23 to
4fff039
Compare
jdylanmc
marked this pull request as ready for review
September 28, 2026 22:38
This was referenced Sep 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: #75 Calendar component isolation
Existing PR97, related #18; no issue closure. Explicit Calendar service, owned Defaults selection key and initial date enable synthetic-provider tests without fixture access to personal Calendar data, OS grants or real reminder mutations. Production shared singleton retains its real EventKit provider, selection key, observer and initial reload.
Intentional coupled fixes
Publish initial authorization state before awaiting provider access, resolve initial lists before date/selection operations, compare selected ID membership rather than counts, and prevent unavailable nonempty explicit selections becoming the providers empty-ID/all-calendar wildcard. Existing deliberate empty-selection fallback and error logging remain. Overlapping async response ordering is not addressed.
Acceptance evidence
Current candidate and validation
Head4fff039f5a62249c7ac84466c5cb0c124b2c9a06 on current pocket38074c12b3eeeb0feb2e2ea79c905fdfd3ef2998. Range-diff confirms original implementation patch is identical; the follow-up adds the scoped Unreleased changelog and corrects a stale Calendar Settings coverage entry while preserving Settings95 evidence.
Current local evidence: app build and all206 tests pass (18 Calendar); 69 helper tests; 170 workflow contracts; 22 PR-policy tests; 226 Python tests. App/helper lint pass their unchanged non-strict gates with recorded warnings; no warnings suppressed. The missing YAML dependency was restored through exact-lockfile npm ci only after the actual missing-dependency failure. App validation used isolated build output; the original running app/process/executable stayed unchanged.
Independent whole-deliverable Roast completed for head4fff039 against base38074c12, with no significant findings. Requirements and worktrees/SOLID/testing/laziness standards were covered; the reviewer independently inspected source, the full XCTest result bundle and supporting logs. Same-session Shepherd has taken custody after an actual provider/source/target observation. At 2026-09-28T22:38:50Z, all current-head checks passed, source/target still matched the reviewed pair, and GitHub promotion was read back as isDraft=false. Ready for human signoff at that snapshot; Shepherd continues observing and invalidates readiness on material source/target/review/check changes. Ship/Shepherd do not merge or enable auto-merge.
No new feature, real Calendar/account operation, native UI proof, whole-profile isolation, app installation/replacement, privacy change, release/signing/tag/asset change or broader #75 closure is claimed.