Repository navigation
Harden shared JSON stream cancellation and descriptor lifetime - #109
Merged
Merged
Conversation
This was referenced Oct 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared stream lifetime hardening and coverage
Scoped implementation and validation complete at
0b08f277e0ac038578a5cf68c73309aa1291c144. Necessary work under open #7; this does not close the broader coverage issue.The current
pocketbaseline, including merged #108, was integrated by a normal merge. The four Shared implementation/coverage paths remain byte-identical to reviewed2c482c3; no source history was rewritten.Current validation
0b08f277e0ac038578a5cf68c73309aa1291c144: no blocking code/design findings; necessary and aligned with Grow test coverage, starting with Shared/ #7.0b08f277e0ac038578a5cf68c73309aa1291c144, executable SHA-2562cc692c83387a6e73a47c8f0d630c3a6eafe7cdf0590074657cd08168073bb94, version 0.1.0 (272), six code files/thirteen architecture signatures. Developer ID signed, NOT YET NOTARIZED, installed only in the owned guest with the previous app preserved.abfc8a2; it was not rebuilt, re-signed or reauthorized for this candidate.Native results and preserved metadata qualification
The fresh candidate passed one About admission and the full nine-case suite:
four functional PASS results and five controls with the expected two FAIL /
three BLOCKED outcomes, zero skips, actual before/after capture preflight true.
App/UI/pointer, jobs, processes and suite lock were restored/cleared normally.
Code, modes, symlinks, thirteen signatures and scoped preferences/data remained
unchanged.
The original first-run wrapper report remains BLOCKED: the app root gained
com.apple.maclcontaining 72 zero bytes and its ctime changed, violating thatassignment's additional exact-metadata condition. The native suite result
remains PASS. No writer attribution, harmlessness or unchanged permission
semantics is claimed; no attribute was stripped or report rewritten.
A new predefined repeat-preservation observation used the prior run's actual
AFTER state, not invented metadata. It verified the stopped candidate, then
captured before-launch, after-launch/before-UI and after-About/quit/restoration
snapshots. All recorded content, signatures, xattrs, filesystem metadata and
scoped preferences/data were unchanged across all three in-boot phases. One
About case passed with both preflights true; the full suite was not rerun.
This establishes that separate repeat-preservation result, not retrospective
first-launch metadata equality or an exception to the original report.
These facts satisfy the scoped Shared behavior/unit and signed-candidate
Settings-preservation criteria. They do not claim universal filesystem
metadata invariance or live producer integration.
Explicit remaining coverage
Live Now Playing/Lunar producer exit/restart, helper reconnect and whole-app
recovery remain outside these isolated pipe and Settings checks. The unchanged
consumer cleanup boundaries and cooperative callback cancellation are
documented, not silently rewritten in this PR. Keep broader follow-up under
#7; no additional player integration, account use or whole-app coverage is
claimed.
Earlier failures, native reports and raw captures remain local and preserved.
No host app replacement, privacy grant/reset, release or notarization was
performed during this clearance.